[Tool Parser][2/3] Use self.tools instead of request.tools in tool parsers by sfeng33 · Pull Request #38189 · vllm-project/vllm

sfeng33 · 2026-03-26T04:35:02Z

Purpose

Migrate tool parsers to read tools from self.tools (set at construction) instead of request.tools at call time. This is part 2 of the tool parser cleanup series following [Tool Parser][1/3] Pass tools to ToolParser constructor #38029.
Update the base ToolParser.__init__ to filter and store only ChatCompletionToolsParam | FunctionTool instances
Update tests to pass tools at parser construction rather than only via request

Test Plan

pytest tests/tool_parsers

gemini-code-assist

Code Review

This pull request refactors the tool parsing logic by centralizing the tools definition within the AbstractToolParser instance, making it accessible via self.tools instead of passing it as an argument to individual methods. This change simplifies method signatures and streamlines tool management across various tool parsers and their tests. A potential issue was identified in vllm/tool_parsers/abstract_tool_parser.py where the __init__ method's filtering logic for tools might incorrectly exclude valid FunctionTool definitions if they are provided as plain dictionaries, due to the behavior of isinstance with TypedDict.

claude

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

sfeng33 · 2026-03-26T14:59:45Z

@chaunceyjiang @bbrowning

bbrowning

This looks straightforward and a reasonable follow-up to the 1st PR in this series. One note is the _WrappedParser in vllm/parser/abstract_parser.py doesn't pass in tools at all here. I think that's ok for now based on where that gets used in the Responses API path, but we may want to confirm whether that needs some changes as we get to step 3.

sfeng33 · 2026-03-26T20:28:24Z

This looks straightforward and a reasonable follow-up to the 1st PR in this series. One note is the _WrappedParser in vllm/parser/abstract_parser.py doesn't pass in tools at all here. I think that's ok for now based on where that gets used in the Responses API path, but we may want to confirm whether that needs some changes as we get to step 3.

Thanks Ben, this is great reminder to update the unified parser. On a side note - step 3 is blocked util deprecation period is reached.

mergify · 2026-03-30T06:00:06Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @sfeng33.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

sfeng33 · 2026-03-30T23:17:33Z

Resolved conflict

sfeng33 · 2026-03-31T03:06:32Z

@chaunceyjiang would you have any additional comments or feedback on this PR? Thanks!

chaunceyjiang

Thanks~

mergify · 2026-03-31T03:09:38Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @sfeng33.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

chaunceyjiang · 2026-03-31T03:09:54Z

Please rebase the PR

Signed-off-by: sfeng33 <4florafeng@gmail.com>

sfeng33 · 2026-03-31T04:40:32Z

@chaunceyjiang all tests have passed.

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: neweyes <328719365@qq.com>

…llm-project#38189) After the refactor in vllm-project#38189 to use self.tools instead of request.tools, anyOf regression tests need to provide tools at parser construction time so the schema is available for type resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ben Browning <bbrownin@redhat.com>

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Rishi Puri <riship@nvidia.com>

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

mergify Bot added deepseek Related to DeepSeek models qwen Related to Qwen models tool-calling labels Mar 26, 2026

github-project-automation Bot added this to Tool Calling Mar 26, 2026

gemini-code-assist Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread vllm/tool_parsers/abstract_tool_parser.py

sfeng33 marked this pull request as ready for review March 26, 2026 05:02

sfeng33 requested review from aarnphm and chaunceyjiang as code owners March 26, 2026 05:02

claude Bot reviewed Mar 26, 2026

View reviewed changes

bbrowning approved these changes Mar 26, 2026

View reviewed changes

chaunceyjiang reviewed Mar 27, 2026

View reviewed changes

Comment thread vllm/tool_parsers/abstract_tool_parser.py

mergify Bot added the needs-rebase label Mar 30, 2026

sfeng33 force-pushed the cleanup-tool-p2 branch from 3f99df6 to c20983c Compare March 30, 2026 23:16

mergify Bot removed the needs-rebase label Mar 30, 2026

chaunceyjiang approved these changes Mar 31, 2026

View reviewed changes

chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2026

mergify Bot added the needs-rebase label Mar 31, 2026

pr2

e19de24

Signed-off-by: sfeng33 <4florafeng@gmail.com>

sfeng33 force-pushed the cleanup-tool-p2 branch from c20983c to e19de24 Compare March 31, 2026 03:14

mergify Bot removed the needs-rebase label Mar 31, 2026

chaunceyjiang merged commit d53cb9c into vllm-project:main Mar 31, 2026
47 checks passed

github-project-automation Bot moved this to Done in Tool Calling Mar 31, 2026

sfeng33 deleted the cleanup-tool-p2 branch March 31, 2026 06:04

neweyes pushed a commit to neweyes/vllm that referenced this pull request Mar 31, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

dc7a70e

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: neweyes <328719365@qq.com>

bbrowning mentioned this pull request Apr 2, 2026

[Bugfix] Fix Qwen3CoderToolParser anyOf/oneOf type resolution for nullable params #37831

Merged

sfeng33 mentioned this pull request Apr 3, 2026

[Parser] Pass request.tools to tool parser #38860

Merged

AAISSJ mentioned this pull request Apr 4, 2026

[ToolParser][Bugfix] Re-land: Fix anyOf/oneOf/$ref type resolution in Qwen3CoderToolParser (#37831) #38973

Merged

mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

3b0a182

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

2d45d23

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

7e835c0

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

1a0dfd2

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026

[Tool Parser][2/3] Use self.tools instead of request.tools in tool pa…

d1f5b51

…rsers (vllm-project#38189) Signed-off-by: sfeng33 <4florafeng@gmail.com>

Uh oh!

Conversation

sfeng33 commented Mar 26, 2026

Purpose

Test Plan

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

sfeng33 commented Mar 26, 2026

Uh oh!

bbrowning left a comment

Choose a reason for hiding this comment

Uh oh!

sfeng33 commented Mar 26, 2026

Uh oh!

Uh oh!

mergify Bot commented Mar 30, 2026

Uh oh!

sfeng33 commented Mar 30, 2026

Uh oh!

sfeng33 commented Mar 31, 2026

Uh oh!

chaunceyjiang left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Mar 31, 2026

Uh oh!

chaunceyjiang commented Mar 31, 2026

Uh oh!

sfeng33 commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants