fix: guard disposable and optional `body` by sheremet-va · Pull Request #9912 · vitest-dev/vitest

sheremet-va · 2026-03-19T12:53:45Z

Description

Resolves #9854

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2026-03-19T12:54:59Z

✅ Deploy Preview for vitest-dev ready!

Name	Link
🔨 Latest commit	`49baffc`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/69bd2c6621a5370009b8ce28
😎 Deploy Preview	https://deploy-preview-9912--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2026-03-19T12:55:00Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@9912

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@9912

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@9912

@vitest/browser-webdriverio

npm i https://pkg.pr.new/@vitest/browser-webdriverio@9912

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@9912

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@9912

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@9912

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@9912

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@9912

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@9912

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@9912

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@9912

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@9912

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@9912

vitest

npm i https://pkg.pr.new/vitest@9912

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@9912

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@9912

commit: 49baffc

hi-ogawa

Can you add tests in test/cli/dts?

sheremet-va · 2026-03-20T10:50:18Z

test/cli/dts

~~Are you sure it works properly? It has exactOptionalPropertyTypes test, but it didn't catch the issue~~ Ah, well, it doesn't import from vitest

sheremet-va · 2026-03-20T11:16:06Z

Can you add tests in test/cli/dts?

Added tests. Verified they fail on main (had to add types: [] to remove @types/node) and work in this branch

I split optional tests int two folders because we need skipLibCheck": false, but our Node dependencies actually break with it. Fortunately, we only need to check imports inside vitest which doesn't use Node types

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | devDependencies | patch | [`8.57.0` → `8.57.2`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.57.0/8.57.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | devDependencies | patch | [`8.57.0` → `8.57.2`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.57.0/8.57.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [i18next](https://www.i18next.com) ([source](https://github.com/i18next/i18next)) | dependencies | patch | [`25.10.9` → `25.10.10`](https://renovatebot.com/diffs/npm/i18next/25.10.9/25.10.10) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/i18next/i18next/badge)](https://securityscorecards.dev/viewer/?uri=github.com/i18next/i18next) | | [react-router-dom](https://github.com/remix-run/react-router) ([source](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)) | dependencies | patch | [`7.13.1` → `7.13.2`](https://renovatebot.com/diffs/npm/react-router-dom/7.13.1/7.13.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/remix-run/react-router/badge)](https://securityscorecards.dev/viewer/?uri=github.com/remix-run/react-router) | | [typescript-eslint](https://typescript-eslint.io/packages/typescript-eslint) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint)) | devDependencies | patch | [`8.57.0` → `8.57.2`](https://renovatebot.com/diffs/npm/typescript-eslint/8.57.0/8.57.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [vitest](https://vitest.dev) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`4.1.0` → `4.1.2`](https://renovatebot.com/diffs/npm/vitest/4.1.0/4.1.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vitest-dev/vitest/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vitest-dev/vitest) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.57.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8572-2026-03-23) [Compare Source](typescript-eslint/typescript-eslint@v8.57.1...v8.57.2) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] preserve type alias infomation ([#11954](typescript-eslint/typescript-eslint#11954)) - **eslint-plugin:** \[no-useless-default-assignment] skip reporting false positives for unresolved type parameters ([#12127](typescript-eslint/typescript-eslint#12127)) - **eslint-plugin:** \[no-unsafe-return] false positive on unwrapping generic ([#12125](typescript-eslint/typescript-eslint#12125)) - **eslint-plugin:** \[no-restricted-types] flag banned generics in extends or implements ([#12120](typescript-eslint/typescript-eslint#12120)) - **eslint-plugin:** \[array-type] ignore Array and ReadonlyArray without type arguments ([#11971](typescript-eslint/typescript-eslint#11971)) - **eslint-plugin:** \[prefer-optional-chain] remove dangling closing parenthesis ([#11865](typescript-eslint/typescript-eslint#11865)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Konv Suu - mdm317 - Newton Yuan [@NewtonYuan](https://github.com/NewtonYuan) - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Tamashoo [@Tamashoo](https://github.com/Tamashoo) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.2) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.57.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8571-2026-03-16) [Compare Source](typescript-eslint/typescript-eslint@v8.57.0...v8.57.1) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] no report for property on intersection type ([#12126](typescript-eslint/typescript-eslint#12126)) ##### ❤️ Thank You - Newton Yuan [@NewtonYuan](https://github.com/NewtonYuan) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.1) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.57.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8572-2026-03-23) [Compare Source](typescript-eslint/typescript-eslint@v8.57.1...v8.57.2) This was a version bump only for parser to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.2) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.57.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8571-2026-03-16) [Compare Source](typescript-eslint/typescript-eslint@v8.57.0...v8.57.1) This was a version bump only for parser to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.1) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>i18next/i18next (i18next)</summary> ### [`v25.10.10`](https://github.com/i18next/i18next/blob/HEAD/CHANGELOG.md#251010) [Compare Source](i18next/i18next@v25.10.9...v25.10.10) - feat: suppress support notice automatically in production environments (`NODE_ENV=production`) </details> <details> <summary>remix-run/react-router (react-router-dom)</summary> ### [`v7.13.2`](https://github.com/remix-run/react-router/blob/HEAD/packages/react-router-dom/CHANGELOG.md#7132) [Compare Source](https://github.com/remix-run/react-router/compare/react-router-dom@7.13.1...react-router-dom@7.13.2) ##### Patch Changes - Updated dependencies: - `react-router@7.13.2` </details> <details> <summary>typescript-eslint/typescript-eslint (typescript-eslint)</summary> ### [`v8.57.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8572-2026-03-23) [Compare Source](typescript-eslint/typescript-eslint@v8.57.1...v8.57.2) This was a version bump only for typescript-eslint to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.2) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.57.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8571-2026-03-16) [Compare Source](typescript-eslint/typescript-eslint@v8.57.0...v8.57.1) This was a version bump only for typescript-eslint to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.1) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>vitest-dev/vitest (vitest)</summary> ### [`v4.1.2`](https://github.com/vitest-dev/vitest/releases/tag/v4.1.2) [Compare Source](vitest-dev/vitest@v4.1.1...v4.1.2) This release bumps Vitest's `flatted` version and removes version pinning to resolve `flatted`'s CVE related issues ([#9975](vitest-dev/vitest#9975)). ##### 🐞 Bug Fixes - Don't resolve `setupFiles` from parent directory - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9960](vitest-dev/vitest#9960) [<samp>(7aa93)</samp>](vitest-dev/vitest@7aa937776) - Ensure sequential mock/unmock resolution - by [@hi-ogawa](https://github.com/hi-ogawa) and **Claude Opus 4.6** in [#9830](vitest-dev/vitest#9830) [<samp>(7c065)</samp>](vitest-dev/vitest@7c06598db) - **browser**: Take failure screenshot if `toMatchScreenshot` can't capture a stable screenshot - by [@macarie](https://github.com/macarie) in [#9847](vitest-dev/vitest#9847) [<samp>(faace)</samp>](vitest-dev/vitest@faace1fbe) - **coverage**: Correct `coverageConfigDefaults` values and types - by [@Arthie](https://github.com/Arthie) in [#9940](vitest-dev/vitest#9940) [<samp>(b3c99)</samp>](vitest-dev/vitest@b3c992cb2) - **pretty-format**: Fix output limit over counting - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9965](vitest-dev/vitest#9965) [<samp>(d3b7a)</samp>](vitest-dev/vitest@d3b7a40fa) - Disable colors if agent is detected - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in [#9851](vitest-dev/vitest#9851) [<samp>(6f97b)</samp>](vitest-dev/vitest@6f97b55dd) ##### [View changes on GitHub](vitest-dev/vitest@v4.1.1...v4.1.2) ### [`v4.1.1`](https://github.com/vitest-dev/vitest/releases/tag/v4.1.1) [Compare Source](vitest-dev/vitest@v4.1.0...v4.1.1) ##### 🚀 Features - **experimental**: - Expose `matchesTags` to test if the current filter matches tags - by [@sheremet-va](https://github.com/sheremet-va) in [#9913](vitest-dev/vitest#9913) [<samp>(eec53)</samp>](vitest-dev/vitest@eec53d9f5) - Introduce `experimental.vcsProvider` - by [@sheremet-va](https://github.com/sheremet-va) in [#9928](vitest-dev/vitest#9928) [<samp>(56115)</samp>](vitest-dev/vitest@561150036) ##### 🐞 Bug Fixes - Mark `TestProject.testFilesList` internal properly - by [@sapphi-red](https://github.com/sapphi-red) in [#9867](vitest-dev/vitest#9867) [<samp>(54f26)</samp>](vitest-dev/vitest@54f2660f5) - Detect fixture that returns without calling `use` - by [@oilater](https://github.com/oilater) in [#9831](vitest-dev/vitest#9831) and [#9861](vitest-dev/vitest#9861) [<samp>(633ae)</samp>](vitest-dev/vitest@633ae2303) - Drop vite 8.beta support - by [@AriPerkkio](https://github.com/AriPerkkio) in [#9862](vitest-dev/vitest#9862) [<samp>(b78f5)</samp>](vitest-dev/vitest@b78f5389d) - Type regression in vi.mocked() static class methods - by [@purepear](https://github.com/purepear) and [@hi-ogawa](https://github.com/hi-ogawa) in [#9857](vitest-dev/vitest#9857) [<samp>(90926)</samp>](vitest-dev/vitest@90926641b) - Properly re-evaluate actual modules of mocked external - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9898](vitest-dev/vitest#9898) [<samp>(ae5ec)</samp>](vitest-dev/vitest@ae5ec03ef) - Preserve coverage report when html reporter overlaps - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9889](vitest-dev/vitest#9889) [<samp>(2d81a)</samp>](vitest-dev/vitest@2d81ad897) - Provide `vi.advanceTimers` to the preview provider - by [@sheremet-va](https://github.com/sheremet-va) in [#9891](vitest-dev/vitest#9891) [<samp>(1bc3e)</samp>](vitest-dev/vitest@1bc3e63be) - Don't leak event listener in playwright provider - by [@sheremet-va](https://github.com/sheremet-va) in [#9910](vitest-dev/vitest#9910) [<samp>(d9355)</samp>](vitest-dev/vitest@d93550ff7) - Open browser in `--standalone` mode without running tests - by [@sheremet-va](https://github.com/sheremet-va) in [#9911](vitest-dev/vitest#9911) [<samp>(e78ad)</samp>](vitest-dev/vitest@e78adcf97) - Guard disposable and optional `body` - by [@sheremet-va](https://github.com/sheremet-va) in [#9912](vitest-dev/vitest#9912) [<samp>(6fdb2)</samp>](vitest-dev/vitest@6fdb2ba61) - Resolve `retry.condition` RegExp serialization issue - by [@nstepien](https://github.com/nstepien) and [@hi-ogawa](https://github.com/hi-ogawa) in [#9942](vitest-dev/vitest#9942) [<samp>(7b605)</samp>](vitest-dev/vitest@7b6054328) - **collect**: - Don't treat extra props on `test` return as tests - by [@sheremet-va](https://github.com/sheremet-va) in [#9871](vitest-dev/vitest#9871) [<samp>(141e7)</samp>](vitest-dev/vitest@141e72aa1) - **coverage**: - Simplify provider types - by [@AriPerkkio](https://github.com/AriPerkkio) in [#9931](vitest-dev/vitest#9931) [<samp>(aaf9f)</samp>](vitest-dev/vitest@aaf9f18ae) - Load built-in provider without module runner - by [@AriPerkkio](https://github.com/AriPerkkio) in [#9939](vitest-dev/vitest#9939) [<samp>(bf892)</samp>](vitest-dev/vitest@bf8920817) - **expect**: - Soft assertions continue after .resolves/.rejects promise errors - by [@mixelburg](https://github.com/mixelburg), **Maks Pikov**, **Claude Opus 4.6 (1M context)** and [@hi-ogawa](https://github.com/hi-ogawa) in [#9843](vitest-dev/vitest#9843) [<samp>(6d74b)</samp>](vitest-dev/vitest@6d74b4948) - Fix sinon-chai style API - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9943](vitest-dev/vitest#9943) [<samp>(0f08d)</samp>](vitest-dev/vitest@0f08dda2c) - **pretty-format**: - Limit output for large object - by [@hi-ogawa](https://github.com/hi-ogawa) and **Claude Opus 4.6 (1M context)** in [#9949](vitest-dev/vitest#9949) [<samp>(0d5f9)</samp>](vitest-dev/vitest@0d5f9d6ef) ##### [View changes on GitHub](vitest-dev/vitest@v4.1.0...v4.1.1) </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!411 Co-authored-by: persistent-chamoisee yield <persistent-chamoisee-yield-9fd-f86-2e0-f31d23b2e@swiss-armed-forces-open-source.ch>

fix: guard disposable and optional body

2bfeb1d

sheremet-va added the cr-tracked label Mar 19, 2026

sheremet-va added 3 commits March 19, 2026 14:05

chore: use optional-types.d.ts trick

6fd361a

chore: external

de5b842

fix: the wrong type

2695d70

sheremet-va mentioned this pull request Mar 19, 2026

Typings issues with exactOptionalPropertyTypes and Disposable #9854

Closed

6 tasks

sheremet-va requested a review from hi-ogawa March 19, 2026 13:19

fix: have a separate file for disposable

5c2606f

hi-ogawa reviewed Mar 20, 2026

View reviewed changes

test: add dts tests

49baffc

hi-ogawa approved these changes Mar 21, 2026

View reviewed changes

hi-ogawa merged commit 6fdb2ba into vitest-dev:main Mar 21, 2026
16 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: guard disposable and optional `body`#9912

fix: guard disposable and optional `body`#9912
hi-ogawa merged 6 commits intovitest-dev:mainfrom
sheremet-va:fix/type-issues

sheremet-va commented Mar 19, 2026

Uh oh!

netlify bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

hi-ogawa left a comment

Uh oh!

sheremet-va commented Mar 20, 2026 •

edited

Loading

Uh oh!

sheremet-va commented Mar 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sheremet-va commented Mar 19, 2026

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

pkg-pr-new bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

sheremet-va commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheremet-va commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 19, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 19, 2026 •

edited

Loading

sheremet-va commented Mar 20, 2026 •

edited

Loading

sheremet-va commented Mar 20, 2026 •

edited

Loading