fix(pretty-format): limit output for large object#9949
Merged
sheremet-va merged 14 commits intovitest-dev:mainfrom Mar 23, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Change kill-switch from maxDepth = -1 to maxDepth = 0 (equivalent behavior, clearer intent). Add test suite visualizing the budget behavior: early elements expanded, later elements folded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sheremet-va
approved these changes
Mar 23, 2026
This was referenced Mar 24, 2026
Contributor
|
This is a breaking change imho as it breaks existing snapshots that are above 1MB, should have been labeled as such. |
|
Broke some of our tests as well. I could see how this is a bug fix, but I don't understand how we can set this limit, is it not possible or just undocumented? |
Collaborator
Author
|
This had a bug. Would appreciate if you can try it out next attempt with loose and likely more reasonable default limit. #9965 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several approaches is mentioned in the note above. This PR took the simplest approach inspired by Node's
util.inspect. See 2nd approach in the note.This doesn't necessarily supersede #9920 since that's more about heuristics of improving the error diff for obvious case. This PR is only about implementing the guard for worst case.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.