Skip to content

fix: shallow diff between different primitive types#9920

Closed
hi-ogawa wants to merge 1 commit intovitest-dev:mainfrom
hi-ogawa:03-20-fix_minimize_diff_between_different_primitive_types
Closed

fix: shallow diff between different primitive types#9920
hi-ogawa wants to merge 1 commit intovitest-dev:mainfrom
hi-ogawa:03-20-fix_minimize_diff_between_different_primitive_types

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Mar 20, 2026

Description

Another heuristics approach to save this failure pattern similar #7133.

I think the robust solution would be to bake in truncate-and-bail-out logic inside pretty-format, which is likely do-able now. I'm interested to look into along with #9609.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 64b7883
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69bcabb66502b80008e9363c
😎 Deploy Preview https://deploy-preview-9920--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa changed the title fix: minimize diff between different primitive types fix: shallow diff between different primitive types Mar 20, 2026
@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

Closing until anyone still complains after the fix #9949

@hi-ogawa hi-ogawa closed this Mar 24, 2026
@hi-ogawa hi-ogawa deleted the 03-20-fix_minimize_diff_between_different_primitive_types branch March 24, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expect(object).toBeUndefined causes memory leak

1 participant