Backport to v14: VReplication: more unrecoverable error codes (#10559)#10562
Merged
shlomi-noach merged 1 commit intovitessio:release-14.0from Jun 22, 2022
Conversation
* VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
dbussink
approved these changes
Jun 22, 2022
Contributor
Author
|
Two in-progress tests have been like that for hours now. Restarting them. Otherwise, just merging. |
Contributor
Author
|
Unable to cancel these tests. They just keep on running. |
Contributor
Author
|
Again, the two |
frouioui
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10559. This is a bugfix that's worth backporting to v14.
Description
followup to #9973, #10390, #10394
Adding error codes related to
DATETIMEvalue conversion/truncation. This will fail aVReplicationworkflow, and specifically an Online DDLvitessmigration, immediately upon receipt of such error.Related Issue(s)
#6926
Checklist
Deployment Notes