Skip to content

OnlineDDL/vrepl: more error codes, spatial types#10394

Merged
shlomi-noach merged 3 commits intovitessio:mainfrom
planetscale:onlineddl-vrepl-more-error-codes-and-tests
May 31, 2022
Merged

OnlineDDL/vrepl: more error codes, spatial types#10394
shlomi-noach merged 3 commits intovitessio:mainfrom
planetscale:onlineddl-vrepl-more-error-codes-and-tests

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach commented May 31, 2022

Description

This PR introduces several spatial types related errors, which are now deemed as "unrecoverable" vreplication errors.
Adding a single spatial casting test (validates one of those error codes)

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
more vreplication unrecoverable errors
18eeb2d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
error code 1416
dc28960 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
add geometry cast tests
ddaf1af 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from dbussink May 31, 2022 08:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 31, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

rohit-nayak-ps
rohit-nayak-ps approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shlomi-noach shlomi-noach merged commit defc201 into vitessio:main May 31, 2022
@shlomi-noach shlomi-noach deleted the onlineddl-vrepl-more-error-codes-and-tests branch May 31, 2022 11:58
This was referenced Jun 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees

No one assigned

Labels

Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomi-noach @dbussink @rohit-nayak-ps