OnlineDDL/vitess fix: convert data type to JSON #10390
Merged
shlomi-noach merged 4 commits intovitessio:mainfrom May 31, 2022
Merged
OnlineDDL/vitess fix: convert data type to JSON #10390shlomi-noach merged 4 commits intovitessio:mainfrom
shlomi-noach merged 4 commits intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…8mb4)' Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
rohit-nayak-ps
approved these changes
May 31, 2022
Member
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
lgtm
The gh-ost test failed once and succeeded the second time, but as we have found the action still failed. Restarted it: we should keep an eye out since we have found recently that many of the flaky tests did have underlying bugs.
3 tasks
This was referenced Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
vitessmigrations where a column is modified from a non-JSONtype intoJSON. When converting toJSON,vreplicationadds aconvert(%v using utf8mb4)wrapper around the column. However, because in our scenario the original column is non-JSON, the wrapper is not added.We now analyze the scenario where source column is non-
JSONand target column isJSON, and ensure to addconvert()around the column name.Also, this PR now identifies a series of errors as non-recoverable, such that a
vreplicationstream will fail the moment it encounters them. The added errors are allJSONconversion -related (e.g. empty document, invalid JSON format, data too long, etc.)vrepl_suitetests are added to cover multiple scenarios.Related Issue(s)
#6926
Checklist
Deployment Notes