fix(resolver): skip known ESM entries when resolving a require call #7582
Merged
patak-cat merged 4 commits intovitejs:mainfrom Apr 2, 2022
Merged
fix(resolver): skip known ESM entries when resolving a require call #7582patak-cat merged 4 commits intovitejs:mainfrom
require call #7582patak-cat merged 4 commits intovitejs:mainfrom
Conversation
Member
|
I think this PR will also fix #7376. |
haoqunjiang
commented
Apr 2, 2022
| 'es2015', | ||
| 'es2020', | ||
| 'fesm2015', | ||
| 'fesm2020' |
Member
Author
There was a problem hiding this comment.
I didn't add esm and module-browser because I can't find any real-world use cases of them.
esnext is used by foundation-sites, es20** and fesm20** are used by Angular CLI.
patak-cat
approved these changes
Apr 2, 2022
7 tasks
7 tasks
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7578
Additional context
The name of #7438 test case wasn't accurate enough so I changed it in this PR.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).