Skip to content

chore: upgrade sirv#4600

Merged
antfu merged 1 commit intovitejs:mainfrom
benmccann:sirv-upgrade
Aug 16, 2021
Merged

chore: upgrade sirv#4600
antfu merged 1 commit intovitejs:mainfrom
benmccann:sirv-upgrade

Conversation

@benmccann
Copy link
Copy Markdown
Collaborator

Description

Upgrade sirv

Additional context

We just fixed a bug in sirv that affected SvelteKit and I saw Vite was also working around it in #1432 / #2201


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann marked this pull request as draft August 14, 2021 00:02
@benmccann benmccann marked this pull request as ready for review August 14, 2021 01:43
@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Aug 14, 2021
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 14, 2021
@antfu antfu merged commit dbfd931 into vitejs:main Aug 16, 2021
@hyf0 hyf0 mentioned this pull request Aug 17, 2021
9 tasks
@hannoeru hannoeru mentioned this pull request Aug 25, 2021
9 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants