fix: decode url before serving static files#2201
Merged
yyx990803 merged 4 commits intovitejs:mainfrom Feb 26, 2021
CHOYSEN:patch_decode
Merged
fix: decode url before serving static files#2201yyx990803 merged 4 commits intovitejs:mainfrom CHOYSEN:patch_decode
yyx990803 merged 4 commits intovitejs:mainfrom
CHOYSEN:patch_decode
Conversation
Contributor
Author
|
The test relies on the following code: vite/packages/playground/assets/__tests__/assets.spec.ts Lines 17 to 21 in 52f7370 |
Member
|
I think we should add a middleware to decode all incoming URLs before other middlewares so that we can just remove the following: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2195