fix: revert resolve nested dependencies #3753#4019
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jun 29, 2021
patak-cat:revert/3254
Merged
fix: revert resolve nested dependencies #3753#4019patak-cat merged 1 commit intovitejs:mainfrom patak-cat:revert/3254
patak-cat merged 1 commit intovitejs:mainfrom
patak-cat:revert/3254
Conversation
antfu
approved these changes
Jun 29, 2021
Member
|
Do we want to make a hotfix after this? |
Member
Author
|
Yelmor said it doesn't look like an easy fix. I think we need to leave it for 2.4.x, when a proper solution is found |
Member
|
Yeah I mean hotfix release 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4005
Description
Revert #3753, as discussed with @Yelmor.
I only reverted the code change in packages/vite/src/node/optimizer/esbuildDepPlugin.ts, and left the test suite with a TODO: until #3573 is reworked to fix #3254 again.
Additional context
Tested that #4005 is working correctly after this PR
Probably also fixes #4012 and #4014, I'll ask them to test once this is merged
What is the purpose of this pull request?