Skip to content

fix: resolve nested dependencies (#3254)#3753

Merged
patak-cat merged 5 commits intovitejs:mainfrom
Yelmor:main
Jun 27, 2021
Merged

fix: resolve nested dependencies (#3254)#3753
patak-cat merged 5 commits intovitejs:mainfrom
Yelmor:main

Conversation

@Yelmor
Copy link
Contributor

@Yelmor Yelmor commented Jun 10, 2021

Description

Current vite(2.3.7) cannot resolve nested package on dev mode.

If a project has dependencies like this:

.
└── node_modules
    ├── package-a@2.0.0
    │   └── package.json
    └── package-b@1.0.0
        ├── node_modules
        │   └── pacakge-a@1.0.0
        │       └── package.json
        └── package.json

Only package-a@2.0.0 will be load at runtime, and package-b actually import package-a@2.0.0 instead of package-a@1.0.0 .

Additional context

There was two fixes before.

#3003 uses resolveDir as module location, which worked. But it mistakenly use flatId as module path, causing scoped package cannot be resolved.

#3053 changed flatId to qualified[flatId], which fixed scoped package problem, but again the nested pacakge problem occurs.

I'm not sure if this commit finnally fix the problem, or causing further errors, it passed the tests anyway.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 reviewed Jun 10, 2021
View reviewed changes
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 10, 2021
@Yelmor Yelmor requested a review from Shinigami92 June 26, 2021 07:13
@Yelmor
Copy link
Contributor Author

Yelmor commented Jun 27, 2021

Awesome! So this fix can be merged now?

@patak-cat patak-cat merged commit 8467f64 into vitejs:main Jun 27, 2021
@IanVS IanVS mentioned this pull request Jun 29, 2021
Closed
6 tasks
@patak-cat
Copy link
Member

patak-cat commented Jun 29, 2021

@Yelmor would you check #4005? Looks like react-query devtools are breaking after this PR. If it is not something easy to solve, maybe we should revert this one for 2.4.0 and keep iterating on it

@patak-cat patak-cat mentioned this pull request Jun 29, 2021
Closed
6 tasks
@Yelmor
Copy link
Contributor Author

Yelmor commented Jun 29, 2021

@Yelmor would you check #4005? Looks like react-query devtools are breaking after this PR. If it is not something easy to solve, maybe we should revert this one for 2.4.0 and keep iterating on it

I checked the demo and find out that the dependency react-query should resolve to /node_modules/react-query/es/index.js but the nodejs require.resolve resolves it to /node_modules/react-query/lib/index.js.

And I checked the code, vite has it's own way to resolve deps, it creates PluginContainer and uses plugins to do that.

So using single require.resolve is not the correct way to fix the problem.

It seems not easy to extract a independent funciton to resolve sub-deps path from deps directory in vite's way.

You may revert this fix for current release, but we still need to find a way to fix the problem.

@patak-cat
Copy link
Member

patak-cat commented Jun 29, 2021

Thanks for looking into this. It seems there are two other related issues #4014 and #4012. I think we should revert and keep working on a solution

@patak-cat patak-cat mentioned this pull request Jun 29, 2021
Merged
4 tasks
patak-cat added a commit that referenced this pull request Jun 29, 2021
@patak-cat
fix: revert resolve nested dependencies #3753 (#4019)
b6f4293 
Fixes #4005
@veltman veltman mentioned this pull request Jun 30, 2021
Closed
@Yelmor Yelmor mentioned this pull request Jul 3, 2021
Merged
9 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@Yelmor @antfu @aleclarson
fix: resolve nested dependencies (vitejs#3254) (vitejs#3753)
57bed42 
* fix: resolve nested dependencies (vitejs#3254)

* chore: inline packages

* chore: force optimize

* chore: cleanup

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@patak-cat @aleclarson
fix: revert resolve nested dependencies vitejs#3753 (vitejs#4019)
8c141b0 
Fixes vitejs#4005
@hirokith
Copy link
Contributor

hirokith commented Jan 27, 2022

Thanks for looking into this. It seems there are two other related issues #4014 and #4012. I think we should revert and keep working on a solution

The issue still exists vite@2.7.12, and #4014 and #4012 are closed, is there anyone still working on the issue?

@patak-cat
Copy link
Member

patak-cat commented Jan 27, 2022

@dickeylth would you create a new issue against the latest version of vite (vite@2.8.0-beta.3) so we can properly track the bug report?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

+1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yelmor @patak-cat @hirokith @Shinigami92 @antfu