Skip to content

refactor: use originalFileNames/names#18240

Merged
patak-cat merged 9 commits intovitejs:mainfrom
sapphi-red:refactor/use-original-file-names
Oct 24, 2024
Merged

refactor: use originalFileNames/names#18240
patak-cat merged 9 commits intovitejs:mainfrom
sapphi-red:refactor/use-original-file-names

Conversation

@sapphi-red
Copy link
Member

Description

Use originalFileNames and names which will be added by rollup/rollup#5686.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 30, 2024
@sapphi-red
Copy link
Member Author

I didn't expect the tests to pass. I thought it will fail with rollup's rust part compilation but it seems it works without setup-rust-toolchain action. 😮

@sapphi-red sapphi-red marked this pull request as ready for review October 2, 2024 03:32
@patak-cat
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

patak-cat
patak-cat previously approved these changes Oct 7, 2024
@patak-cat patak-cat added this to the 6.0 milestone Oct 14, 2024
bluwy
bluwy previously approved these changes Oct 24, 2024
@sapphi-red sapphi-red dismissed stale reviews from bluwy and patak-cat via 65d6fb1 October 24, 2024 09:11
@patak-cat patak-cat merged commit f2957c8 into vitejs:main Oct 24, 2024
@sapphi-red sapphi-red deleted the refactor/use-original-file-names branch October 24, 2024 10:53
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 6, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 14, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 14, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 22, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 22, 2024
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Nov 29, 2024
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Dec 4, 2024
<!-- Thank you for contributing! -->

### Description

close #2496

refs #2046,
rollup/rollup#5686,
vitejs/vite#18240

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request Dec 11, 2024
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants