Skip to content

feat: add originalFileName to EmittedAsset#2046

Merged
underfin merged 1 commit intomainfrom
support-originalFIleName
Aug 23, 2024
Merged

feat: add originalFileName to EmittedAsset#2046
underfin merged 1 commit intomainfrom
support-originalFIleName

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Aug 23, 2024

Description

Add originalFileName to EmittedAsset, ref rollup/rollup#5596

@netlify
Copy link

netlify bot commented Aug 23, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5ca57f6
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66c85cb6f6939d00086e70d7

@underfin underfin enabled auto-merge August 23, 2024 10:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     53.3±1.04ms        ? ?/sec    1.02     54.5±3.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     78.6±1.62ms        ? ?/sec    1.04     81.9±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     97.7±3.04ms        ? ?/sec    1.04    101.5±2.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     62.7±1.85ms        ? ?/sec    1.00     62.0±1.41ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.6±0.82ms        ? ?/sec    1.03    104.9±1.68ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    185.5±4.40ms        ? ?/sec    1.03    190.7±5.04ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    232.1±7.09ms        ? ?/sec    1.02    237.4±9.24ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.5±0.70ms        ? ?/sec    1.02    118.4±2.05ms        ? ?/sec
bundle/bundle@threejs                                               1.00     37.4±1.57ms        ? ?/sec    1.01     37.7±0.50ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     84.9±1.77ms        ? ?/sec    1.01     85.5±1.47ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.9±2.63ms        ? ?/sec    1.02    104.0±2.74ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.4±0.41ms        ? ?/sec    1.03     47.7±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    392.7±2.81ms        ? ?/sec    1.02    400.7±4.18ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    987.7±6.99ms        ? ?/sec    1.01    993.6±9.54ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1244.7±9.49ms        ? ?/sec    1.01  1259.9±11.35ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    466.8±6.18ms        ? ?/sec    1.00    465.9±4.03ms        ? ?/sec
remapping/remapping                                                 1.00     32.7±0.29ms        ? ?/sec    1.03     33.6±1.88ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     81.4±0.31ms        ? ?/sec    1.03     84.0±1.07ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.8±1.01ms        ? ?/sec    1.01     83.6±1.03ms        ? ?/sec
scan/scan@threejs                                                   1.00     29.2±0.98ms        ? ?/sec    1.00     29.1±0.30ms        ? ?/sec
scan/scan@threejs10x                                                1.00    293.0±2.10ms        ? ?/sec    1.00    292.3±1.99ms        ? ?/sec

@underfin underfin added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 6facb04 Aug 23, 2024
@underfin underfin deleted the support-originalFIleName branch August 23, 2024 10:19
@sapphi-red sapphi-red mentioned this pull request Dec 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2024
@sapphi-red
feat: names / originalFileNames support (#3024)
daa17ff 
<!-- Thank you for contributing! -->

### Description

close #2496

refs #2046,
rollup/rollup#5686,
vitejs/vite#18240

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0