Conversation
|
|
userquin
reviewed
Apr 18, 2023
sheremet-va
reviewed
Apr 18, 2023
Shinigami92
previously approved these changes
Apr 18, 2023
ArnaudBarre
reviewed
Apr 18, 2023
Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>
Shinigami92
previously approved these changes
Apr 19, 2023
jeffydc
reviewed
Apr 19, 2023
Co-authored-by: Jeff Yang <n2ya@duck.com>
jeffydc
reviewed
Apr 19, 2023
Co-authored-by: Jeff Yang <n2ya@duck.com>
4 tasks
bluwy
reviewed
Jun 5, 2023
Member
There was a problem hiding this comment.
I forgot to review this! I had attempted a document locally too but didn't get really far. Apart from my below suggestion, I had also thought about documenting "YAO", but we could perhaps add that in another day.
EDIT: Actually the first section somewhat covers YAO, perhaps it could be more explicit in we're not extending the Vite config unnecessarily, but I don't have a hard opinion if we need to change it here.
patak-cat
commented
Jun 9, 2023
patak-cat
commented
Jun 15, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
approved these changes
Jun 15, 2023
sapphi-red
approved these changes
Jun 22, 2023
xinxinhe1810
pushed a commit
to xinxinhe1810/vite
that referenced
this pull request
Jul 4, 2023
Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com> Co-authored-by: Jeff Yang <n2ya@duck.com> Co-authored-by: bluwy <bjornlu.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3223
Description
Initial draft. Content to be discussed and also if this section should be in the docs or in the CONTRIBUTING.md.
What is the purpose of this pull request?