Skip to content

Include the variable tabstop feature#2711

Closed
chrisbra wants to merge 1 commit intovim:masterfrom
chrisbra:vartabs
Closed

Include the variable tabstop feature#2711
chrisbra wants to merge 1 commit intovim:masterfrom
chrisbra:vartabs

Conversation

@chrisbra
Copy link
Member

this is the variable tabstop feature from #857

Unfortunately, github closed that PR, when I force pushed an update, so here is the new PR.

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

Merging #2711 into master will increase coverage by <.01%.
The diff coverage is 80.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2711      +/-   ##
==========================================
+ Coverage   75.74%   75.75%   +<.01%     
==========================================
  Files          92       92              
  Lines      135077   135377     +300     
==========================================
+ Hits       102320   102555     +235     
- Misses      32757    32822      +65
Impacted Files Coverage Δ
src/version.c 85.23% <ø> (+2.85%) ⬆️
src/evalfunc.c 84.26% <ø> (ø) ⬆️
src/hardcopy.c 65.79% <0%> (-0.05%) ⬇️
src/beval.c 3.57% <0%> (-0.1%) ⬇️
src/charset.c 88.12% <100%> (+0.01%) ⬆️
src/gui_beval.c 63.24% <100%> (+0.15%) ⬆️
src/buffer.c 78.64% <100%> (+0.09%) ⬆️
src/message.c 74.83% <100%> (ø) ⬆️
src/screen.c 76.63% <100%> (ø) ⬆️
src/ex_cmds.c 79.46% <100%> (+0.08%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6d911...51db702. Read the comment docs.

@chrisbra
Copy link
Member Author

updated to latest master

@eraserhd
Copy link

Is this feature (assuming it is included) the best way to implement computed tabstops? I'm writing a lisp plugin which, based on previous lines of code, knows where code could be indented and I'm wondering whether I should +1 this and update vartabstops and such when the cursor changes line or just nmap and such.

@croscato-zz
Copy link

I am testing this PR right now and it is awesome.
A very nice feature to work with assembly files.
Hope to see this integrated in mainstream soon.

@chrisbra
Copy link
Member Author

Updated for 8.1.0020

@jdek
Copy link

jdek commented Jun 20, 2018

Is there anything I, as a vim user interested in this feature, can do to get this merged quicker/soon?

As a sidenote, anyone using Homebrew can just add to the Formula to use this right away (which works as of current master (a15b0a9).

Add:

  patch do
    url "https://patch-diff.githubusercontent.com/raw/vim/vim/pull/2711.patch"
    sha256 "cc50d3cebae137b74d26f26d1513cc3a95f80819b189fc4bfe90b67413d4dba0"
  end

and:

  opts << "--with-vartabs"

To the relevant areas in brew edit vim.

@brammool brammool closed this in 04958cb Jun 23, 2018
@chrisbra chrisbra deleted the vartabs branch May 6, 2019 07:01
VVKot added a commit to VVKot/neovim that referenced this pull request Jan 30, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Jan 30, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Jan 30, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Feb 13, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Feb 13, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Mar 14, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Mar 14, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
VVKot added a commit to VVKot/neovim that referenced this pull request Mar 28, 2021
Problem:    All tab stops are the same.
Solution:   Add the variable tabstop feature. (Christian Brabandt,
            closes vim/vim#2711)
vim/vim@04958cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants