Skip to content

add variable tabstop feature#857

Closed
chrisbra wants to merge 0 commit intovim:masterfrom
chrisbra:vartabs
Closed

add variable tabstop feature#857
chrisbra wants to merge 0 commit intovim:masterfrom
chrisbra:vartabs

Conversation

@chrisbra
Copy link
Member

Update the variable tabstop feature to the latest version.

Christian Brabandt 20160610

  • fix offsets

Christian Brabandt 20150725

  • fix offsets, fix compiler warnings (option not correctly initialized)

Christian Brabandt 20150609

  • updated offsets and have the tests apply cleanly

Christian Brabandt 20141102:

  • correctly cache vts values when calculating the breakindent

Christian Brabandt 20141030
[DONE] TODO: test_breakindent.out breaks, if instead of using 'ts' setting 'vts' setting is used.
[DONE] TODO: get_breakindent_win should use vts value
[DONE] TODO: get_indent_str_vtab should also use the true/false variable for checking screen size of a tab!

Roland Eggner 2014-10-23 vim-7.4.488
Fixed insertion of 4 lines after src/option.c:5439 -- due to context change in
vim-7.4.456, “hg qrefresh” inserted erroneously with fuzz 2 and -111 lines offset.
Fixed rejections of src/testdir/Make{_{{amiga,dos,ming,os2}.mak,vms.mms},file} .

Roland Eggner 2014-09-09 vim-7.4.430
Readded src/testdir/test_vartabs.{in,ok} based on an older version of this patch.
Fixed rejections of src/testdir/Make{_{{amiga,dos,ming,os2}.mak,vms.mms},file} .

@chrisbra chrisbra force-pushed the vartabs branch 3 times, most recently from 947546e to f98edeb Compare June 10, 2016 15:06
@chrisbra
Copy link
Member Author

chrisbra commented Mar 6, 2017

rebased against 8.0.425 thanks to Danek Duvall

@dhduvall
Copy link
Contributor

dhduvall commented Mar 6, 2017

The test failures (Invalid argument: varsofttabstop=xxx) are because of a missing couple of lines in src/gen_opt_test.vim:

      \ 'varsofttabstop': [['8', '4,8,16,32'], ['xxx', '-1', '4,-1,20']],
      \ 'vartabstop': [['8', '4,8,16,32'], ['xxx', '-1', '4,-1,20']],

@chrisbra
Copy link
Member Author

chrisbra commented Mar 7, 2017

thanks @dhduvall fixed that and changed some ifdefs slightly

@chrisbra chrisbra force-pushed the vartabs branch 2 times, most recently from d0fa824 to 2b6dbff Compare March 29, 2017 05:04
@chrisbra
Copy link
Member Author

updated patch and fix merge conflict in gen_opt_test.vim

@codecov-io
Copy link

Codecov Report

Merging #857 into master will decrease coverage by 0.01%.
The diff coverage is 80.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   74.58%   74.56%   -0.02%     
==========================================
  Files          76       76              
  Lines      124841   125100     +259     
==========================================
+ Hits        93111    93285     +174     
- Misses      31730    31815      +85
Impacted Files Coverage Δ
src/version.c 82.32% <ø> (+2.02%) ⬆️
src/evalfunc.c 80.9% <ø> (ø) ⬆️
src/hardcopy.c 64.98% <0%> (-0.06%) ⬇️
src/charset.c 87.22% <100%> (+0.01%) ⬆️
src/buffer.c 75.2% <100%> (+0.11%) ⬆️
src/screen.c 74.1% <100%> (ø) ⬆️
src/ex_cmds.c 75.63% <100%> (+0.09%) ⬆️
src/message.c 68.04% <100%> (-0.41%) ⬇️
src/gui_beval.c 44.51% <25%> (+0.68%) ⬆️
src/ops.c 77.81% <33.33%> (-0.04%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d3753...2b6dbff. Read the comment docs.

@chrisbra
Copy link
Member Author

not sure why github deleted this PR. Will open a new PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants