Skip to content

Fix: autocompletedelay should not delay menu selection #18048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
girishji wants to merge 3 commits into from
Closed

Fix: autocompletedelay should not delay menu selection #18048

girishji wants to merge 3 commits into from

Conversation

@girishji
Copy link
Contributor

@girishji girishji commented Aug 18, 2025

@gcanat
Copy link
Contributor

gcanat commented Aug 18, 2025

Thanks. I suppose it fixes #18022

@girishji
Copy link
Contributor Author

girishji commented Aug 18, 2025 •
edited
Loading

Thanks. I suppose it fixes #18022

It should. Also, you can tag me. Otherwise, I won't be notified about the bug.

@girishji
Improve test
72153a0 
M  src/testdir/dumps/Test_autocompletedelay_8.dump
M  src/testdir/dumps/Test_autocompletedelay_9.dump
M  src/testdir/test_ins_complete.vim
@girishji girishji mentioned this pull request Aug 18, 2025
Closed
@girishji
Improve test
f2c9026 
M  src/testdir/dumps/Test_autocompletedelay_10.dump
M  src/testdir/dumps/Test_autocompletedelay_8.dump
M  src/testdir/dumps/Test_autocompletedelay_9.dump
M  src/testdir/test_ins_complete.vim
@przepompownia przepompownia mentioned this pull request Aug 19, 2025
Closed
@chrisbra
Copy link
Member

chrisbra commented Aug 20, 2025

thanks

@chrisbra chrisbra closed this in 196c376 Aug 20, 2025
@girishji
Copy link
Contributor Author

girishji commented Aug 20, 2025

Thanks

@girishji girishji deleted the bugacl branch August 20, 2025 19:32
@habamax
Copy link
Contributor

habamax commented Aug 20, 2025 •
edited
Loading

@girishji I believe now there is a regression

briefly:

  1. it doesn't select items
  2. if inserted item is multilined then pmenu is gone

https://asciinema.org/a/4WCRwLNnUvPKxPJ7vxpKQ2fah

@habamax
Copy link
Contributor

habamax commented Aug 20, 2025

for 1) we need at least completeopt+=menuone now to be able to select an item in pmenu with a single element, which wasn't the case before:

vim --clean
:set ac
ihello h<c-n>
image

I can't figure out minimal repro for pmenu with many elements which doesn't select current element yet.

@habamax
Copy link
Contributor

habamax commented Aug 20, 2025 •
edited
Loading

I can't figure out minimal repro for pmenu with many elements which doesn't select current element yet.

and here it is:

  1. vim --clean
  2. :set ac completeopt=popup
  3. ihello help h<C-n>
image

https://asciinema.org/a/L8AFBxb747IDymumk1cDYAw04

@habamax
Copy link
Contributor

habamax commented Aug 20, 2025

for case 2)

multi.vim

func! Multi(findstart, base)
    if a:findstart > 0
        let prefix = getline('.')->strpart(0, col('.') - 1)->matchstr('\S\+$')
        if prefix->empty()
            return -2
        endif
        return col('.') - prefix->len() - 1
    endif
    return ["hello\nworld"]
endfunction
set autocomplete completeopt=popup
set complete+=FMulti
  1. vim --clean +"source multi.vim"
  2. ihello h<C-n><C-n>

pmenu should stay visible but it is cancelled after "hello\nworld" is inserted

https://asciinema.org/a/tICKzxlIvCe8ei3at4ickAwOA

@habamax
Copy link
Contributor

habamax commented Aug 20, 2025

The workaround (for me) is to specify completeopt fully as before ac was introduced set completeopt=menu,menuone,popup,fuzzy

habamax added a commit to habamax/.vim that referenced this pull request Aug 20, 2025
@habamax
now autocomplete can't work alone, needs more completeopts
9853534 
see vim/vim#18048 (comment)
@girishji
Copy link
Contributor Author

girishji commented Aug 21, 2025

@habamax can you try with this: #18068

@habamax
Copy link
Contributor

habamax commented Aug 21, 2025

@habamax can you try with this: #18068

yes, it fixes the issues, thx

@zeertzjq zeertzjq mentioned this pull request Aug 23, 2025
Merged
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
@zeertzjq @girishji
vim-patch:9.1.1657: Autocompletion adds delay
db69a8a 
Problem:  Autocompletion adds delay
          (gcanat, char101, after v9.1.1638)
Solution: Temporarily disable autocomplation (Girish Palya).

related: vim/vim#17960
fixes: vim/vim#18022
closes: vim/vim#18048

vim/vim@196c376

Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
@zeertzjq @girishji
vim-patch:9.1.1657: Autocompletion adds delay
e002747 
Problem:  Autocompletion adds delay
          (gcanat, char101, after v9.1.1638)
Solution: Temporarily disable autocomplation (Girish Palya).

related: vim/vim#17960
fixes: vim/vim#18022
closes: vim/vim#18048

vim/vim@196c376

Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
@zeertzjq @girishji
vim-patch:9.1.1657: Autocompletion adds delay
6ef996a 
Problem:  Autocompletion adds delay
          (gcanat, char101, after v9.1.1638)
Solution: Temporarily disable autocomplation (Girish Palya).

related: vim/vim#17960
fixes: vim/vim#18022
closes: vim/vim#18048

vim/vim@196c376

Co-authored-by: Girish Palya <girishji@gmail.com>
sahinf pushed a commit to sahinf/vim that referenced this pull request Sep 7, 2025
@girishji @sahinf
patch 9.1.1657: Autocompletion adds delay
e7f06fe 
Problem:  Autocompletion adds delay
          (gcanat, char101, after v9.1.1638)
Solution: Temporarily disable autocomplation (Girish Palya).

related: vim#17960
fixes: vim#18022
closes: vim#18048

Signed-off-by: Girish Palya <girishji@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
dundargoc pushed a commit to dundargoc/neovim that referenced this pull request Sep 27, 2025
@zeertzjq @girishji @dundargoc
vim-patch:9.1.1657: Autocompletion adds delay
7b3a869 
Problem:  Autocompletion adds delay
          (gcanat, char101, after v9.1.1638)
Solution: Temporarily disable autocomplation (Girish Palya).

related: vim/vim#17960
fixes: vim/vim#18022
closes: vim/vim#18048

vim/vim@196c376

Co-authored-by: Girish Palya <girishji@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@girishji @gcanat @chrisbra @habamax