Skip to content

Conversation

@girishji
Copy link
Contributor

@girishji girishji commented Aug 20, 2025

Fixes #18044
Also, fix bug where menu items are inserted without being selected.

@chrisbra
Copy link
Member

thanks

zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
Problem:  completion: autocomplete breaks second completion
          (gravndal)
Solution: Fix the autocomplete bug (Girish Palya)

fixes: vim/vim#18044
closes: vim/vim#18068

vim/vim@b4e0bd9

Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
Problem:  completion: autocomplete breaks second completion
          (gravndal)
Solution: Fix the autocomplete bug (Girish Palya)

fixes: vim/vim#18044
closes: vim/vim#18068

vim/vim@b4e0bd9

Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 23, 2025
Problem:  completion: autocomplete breaks second completion
          (gravndal)
Solution: Fix the autocomplete bug (Girish Palya)

fixes: vim/vim#18044
closes: vim/vim#18068

vim/vim@b4e0bd9

Co-authored-by: Girish Palya <girishji@gmail.com>
@girishji
Copy link
Contributor Author

Thanks

@girishji girishji deleted the acbug branch August 23, 2025 14:24
@girishji
Copy link
Contributor Author

@chrisbra This PR is not merged. Please take a look.

@chrisbra
Copy link
Member

Opps, sorry. I am pretty sure I cherry-picked only the last merge commit into master. Either git skipped something for whatever reason or the last merge did not include all changes.

That's one of the reasons I hate merge commits and prefer a linear history which I can easily squash into a single commit.

Anyhow, I hope v9.1.1685 contains the missing changes now. Thanks for noticing.

@chrisbra
Copy link
Member

should be there now: c6a0f42

@girishji
Copy link
Contributor Author

No worries, thanks!

sahinf pushed a commit to sahinf/vim that referenced this pull request Sep 7, 2025
Problem:  completion: autocomplete breaks second completion
          (gravndal)
Solution: Fix the autocomplete bug (Girish Palya)

fixes: vim#18044
closes: vim#18068

Signed-off-by: Girish Palya <girishji@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
dundargoc pushed a commit to dundargoc/neovim that referenced this pull request Sep 27, 2025
Problem:  completion: autocomplete breaks second completion
          (gravndal)
Solution: Fix the autocomplete bug (Girish Palya)

fixes: vim/vim#18044
closes: vim/vim#18068

vim/vim@b4e0bd9

Co-authored-by: Girish Palya <girishji@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete breaks second order ins-completion

2 participants