This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Conversation
…e route handling function is called.
| * @return \Closure | ||
| */ | ||
| private function handleAsAdminSectionRoute($routeHandler) { | ||
| if (!defined('WP_ADMIN')) { |
Contributor
There was a problem hiding this comment.
I think this should be in the callback returned from this method. The WP_ADMIN is now defined for every request if it's here.
Contributor
Author
There was a problem hiding this comment.
Yes you are right. I've fixed that
pavelevap
added a commit
that referenced
this pull request
May 14, 2019
REST requests are handled correctly now (when user is logged in) and there is no need for special method handleAsAdminSectionRoute().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this PR which closes #812. I've changed functionality of rollback,undo, commit as well, because these methods were not handled properly and generated same bug.
Thank you.