Skip to content

[ppr] Add missng .rsc route for non-ppr enabled pages#11681

Merged
wyattjoh merged 8 commits intomainfrom
fix/ppr-prefetch
Jun 4, 2024
Merged

[ppr] Add missng .rsc route for non-ppr enabled pages#11681
wyattjoh merged 8 commits intomainfrom
fix/ppr-prefetch

Conversation

@wyattjoh
Copy link
Copy Markdown
Contributor

When deploying partial prerendering (PPR), there may some pages that are not enabled for PPR but still appear in the prerender-manifest.json. Due to the branching of the client router, these routes also have to have a .rsc as well as a .prefetch.rsc variants in order to prevent 404's. This change adds support for adding the extra route to the prerender for pages that have PPR disabled.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: ee34c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@ztanner ztanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a probe test to confirm that the requests that were previously 404ing do not anymore?

ztanner
ztanner previously approved these changes Jun 3, 2024
@wyattjoh wyattjoh merged commit 4337ea0 into main Jun 4, 2024
@wyattjoh wyattjoh deleted the fix/ppr-prefetch branch June 4, 2024 00:52
ztanner pushed a commit that referenced this pull request Jun 4, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@34.2.5

### Patch Changes

- Adds a route for the `.rsc` pathname as well when app has ppr enabled
but not all routes.
([#11681](#11681))

- Updated dependencies
\[[`7457767a7`](7457767),
[`4337ea065`](4337ea0)]:
    -   @vercel/next@4.2.15

## @vercel/fs-detectors@5.2.4

### Patch Changes

- Add support for detecting Turborepo 2
([#11680](#11680))

## @vercel/next@4.2.15

### Patch Changes

- ensure unmatched action rewrites are routed to correct handler
([#11686](#11686))

- Adds a route for the `.rsc` pathname as well when app has ppr enabled
but not all routes.
([#11681](#11681))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants