[ppr] Add missng .rsc route for non-ppr enabled pages#11681
Merged
Conversation
🦋 Changeset detectedLatest commit: ee34c14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ztanner
reviewed
Jun 3, 2024
Member
ztanner
left a comment
There was a problem hiding this comment.
Could we add a probe test to confirm that the requests that were previously 404ing do not anymore?
ztanner
previously approved these changes
Jun 3, 2024
ztanner
approved these changes
Jun 3, 2024
Merged
ztanner
pushed a commit
that referenced
this pull request
Jun 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.2.5 ### Patch Changes - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) - Updated dependencies \[[`7457767a7`](7457767), [`4337ea065`](4337ea0)]: - @vercel/next@4.2.15 ## @vercel/fs-detectors@5.2.4 ### Patch Changes - Add support for detecting Turborepo 2 ([#11680](#11680)) ## @vercel/next@4.2.15 ### Patch Changes - ensure unmatched action rewrites are routed to correct handler ([#11686](#11686)) - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying partial prerendering (PPR), there may some pages that are not enabled for PPR but still appear in the
prerender-manifest.json. Due to the branching of the client router, these routes also have to have a.rscas well as a.prefetch.rscvariants in order to prevent 404's. This change adds support for adding the extra route to the prerender for pages that have PPR disabled.