feat(turbo): add support for turbo 2 configuration#11680
Merged
chris-olszewski merged 2 commits intomainfrom Jun 4, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 5133646 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8373986 to
fece185
Compare
trek
approved these changes
Jun 4, 2024
jeffsee55
approved these changes
Jun 4, 2024
…upport-pipeline-and-tasks
Contributor
Author
We have that messaging available if someone attempts to use a turbo 1 config with turbo 2 so we'll display that info a little bit later in the build process. |
Merged
ztanner
pushed a commit
that referenced
this pull request
Jun 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.2.5 ### Patch Changes - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) - Updated dependencies \[[`7457767a7`](7457767), [`4337ea065`](4337ea0)]: - @vercel/next@4.2.15 ## @vercel/fs-detectors@5.2.4 ### Patch Changes - Add support for detecting Turborepo 2 ([#11680](#11680)) ## @vercel/next@4.2.15 ### Patch Changes - ensure unmatched action rewrites are routed to correct handler ([#11686](#11686)) - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@chris-olszewski - I'm getting build errors currently when attempting to update to Turbo 2.0 myself, specifically with the turbo.json config. 00:36:46.478 |
00:36:46.478 | x failed to parse turbo json
00:36:46.478 |
00:36:46.479 | Error: turbo_json_parse_error
00:36:46.479 |
00:36:46.479 | x Found an unknown key `tasks`.
00:36:46.479 | ,-[3:1]
00:36:46.479 | 3 \| "globalDependencies": [".env"],
00:36:46.479 | 4 \| "tasks": {
00:36:46.479 | : ^^^^^^^
00:36:46.480 | 5 \| "build": {
00:36:46.480 | `----
00:36:46.480 |
00:36:46.496 | Error: Command "cd ../.. && turbo run build --filter={apps/cms}..." exited with 1
00:36:47.040Is there an issue that has been opened for this? |
|
seeing the same issue as well on vercel build. Error: turbo_json_parse_error no issue on local build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of Turborepo 2 we're renaming
pipelinetotasks.This PR updates the default settings logic to look in
tasksfor abuildtask definition in addition to looking atpipeline. It also updates the message to no longer mention Turbo configuration inpackage.jsonas this is fully ignored in Turborepo 2.Added a quick unit test to verify
buildtask definitions are found in thetaskssection ofturbo.json.Please let me know if there are other tests/places I should update.