Conversation
🦋 Changeset detectedLatest commit: ddcf99e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
reviewed
May 7, 2024
Kikobeats
commented
May 7, 2024
| }); | ||
| } | ||
|
|
||
| (NODE_MAJOR < 18 ? describe.skip : describe)('web handlers', () => { |
Contributor
Author
There was a problem hiding this comment.
@TooTallNate right now CI is only running for Node.js v16, so ALL this test file is skipped; How we can setup a Github Action job just for ensure to run this file using Node.js v18?
TooTallNate
reviewed
May 7, 2024
TooTallNate
previously approved these changes
May 7, 2024
Schniz
reviewed
May 7, 2024
Comment on lines
+187
to
+192
| // @ts-expect-error | ||
| runtime.context.globalThis[Symbol.for('@vercel/request-context')] = { | ||
| get: () => ({ | ||
| waitUntil: params.awaiter.waitUntil.bind(params.awaiter), | ||
| }), | ||
| }; |
Contributor
There was a problem hiding this comment.
what happens if we have two requests concurrently? do we need AsyncLocalStorage?
Contributor
There was a problem hiding this comment.
can we use Object.defineProperty here too?
nuta
reviewed
May 7, 2024
Merged
Kikobeats
pushed a commit
that referenced
this pull request
May 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/functions@1.0.0 ### Major Changes - Initial release ([#11553](#11553)) ## @vercel/node@3.1.0 ### Minor Changes - Make waitUntil consistent for Node.js & Edge ([#11553](#11553)) ## vercel@34.1.9 ### Patch Changes - Updated dependencies \[[`5a532a5b9`](5a532a5), [`50fc27ba5`](50fc27b), [`c1d852295`](c1d8522), [`a5ea04154`](a5ea041)]: - @vercel/next@4.2.8 - @vercel/node@3.1.0 ## @vercel/next@4.2.8 ### Patch Changes - Fix missing initial RSC headers ([#11552](#11552)) - Remove .prefetch.rsc rewrites for non-PPR ([#11540](#11540)) - [next] rename middleware manifest env ([#11549](#11549)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
waitUntilconsistent when interacting with it viavc dev. That includes:be possible to call
waitUntilfrom the context second argument in web handlers functions (Node.js & Edge):be possible to call
waitUntilimported from@vercel/functions(Node.js & Edge):Additionally,
@vercel/functionscan be adopted for other framework to take advantage of this pattern at Vercel.