Skip to content

[next] rename middleware manifest env#11549

Merged
huozhi merged 2 commits into
mainfrom
patch/rename-middleware-env
May 6, 2024
Merged

[next] rename middleware manifest env#11549
huozhi merged 2 commits into
mainfrom
patch/rename-middleware-env

Conversation

@huozhi

@huozhi huozhi commented May 6, 2024

Copy link
Copy Markdown
Contributor

Rename environment property to env from middleware manifest added in #11390.
Align with vercel/next.js#64521

The environments property wasn't working properly before due to unfinished next.js changes, it should work now after testing with next build from vercel/next.js#64521. We change it to a better naming word env.

@changeset-bot

changeset-bot Bot commented May 6, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 35b5949

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to add a test?

Comment thread packages/next/src/utils.ts
@javivelasco

Copy link
Copy Markdown
Member

Any way to add a test?

Since the functionality is already there let's ship the change and then we test in a follow up so we can ship it altogether to production @styfle 🙏

@huozhi huozhi merged commit c1d8522 into main May 6, 2024
@huozhi huozhi deleted the patch/rename-middleware-env branch May 6, 2024 19:32
Kikobeats pushed a commit that referenced this pull request May 7, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/functions@1.0.0

### Major Changes

- Initial release
([#11553](#11553))

## @vercel/node@3.1.0

### Minor Changes

- Make waitUntil consistent for Node.js & Edge
([#11553](#11553))

## vercel@34.1.9

### Patch Changes

- Updated dependencies
\[[`5a532a5b9`](5a532a5),
[`50fc27ba5`](50fc27b),
[`c1d852295`](c1d8522),
[`a5ea04154`](a5ea041)]:
    -   @vercel/next@4.2.8
    -   @vercel/node@3.1.0

## @vercel/next@4.2.8

### Patch Changes

- Fix missing initial RSC headers
([#11552](#11552))

- Remove .prefetch.rsc rewrites for non-PPR
([#11540](#11540))

- [next] rename middleware manifest env
([#11549](#11549))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants