refactor: Clean up test infrastructure + improve test quality#12074
Merged
Conversation
- Add turbo_command() builder, git() helper, combined_output() to common/mod.rs - Add replace_turbo_json_from() for parameterized config replacement - Migrate 10+ test files from local command builders to shared helpers - Eliminate duplicate replace_turbo_json in strict_env_vars.rs and run_summary.rs - Refactor check_json_output! macro to use turbo_command() internally - Rename walkdir -> find_files_by_name, remove unnecessary _inner wrappers - Fix duplicate doc comments in setup.rs
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
32ac08d to
0d350a9
Compare
Contributor
Coverage Report
|
0d350a9 to
bc5fbfd
Compare
…sive I/O - Replace hardcoded hash assertions with relational comparisons in edit_turbo_json.rs (tests hash *changes*, not exact values) - Remove hardcoded hashes from run_caching.rs and run_logging.rs (assert on 'cache miss/hit' without pinning specific hash values) - Replace thread::sleep(1s) in run_summary.rs with deterministic sort-by-cached-count (eliminates a classic flake source) - Reduce big_status_test from 10,000 files to 100 (proves spaces work without the I/O overhead) - Add meaningful assertion to test_single_package_dry_run_pnpm (was only checking exit code, now verifies task output) - Migrate remaining inline git commands to shared common::git() helper in run_caching.rs
bc5fbfd to
abb4493
Compare
github-actions Bot
added a commit
that referenced
this pull request
Mar 2, 2026
## Release v2.8.13-canary.9 Versioned docs: https://v2-8-13-canary-9.turborepo.dev ### Changes - fix: Treat `npm: alias` dependencies as external, not workspace references (#12061) (`b179cb8`) - test: Port 18 more prysk tests to Rust (other/ + lockfile-aware-caching/) (#12062) (`7887af2`) - release(turborepo): 2.8.13-canary.8 (#12063) (`2a5522a`) - fix: Preserve file: protocol entries in pruned yarn v1 lockfile (#12064) (`ae5c1a1`) - perf: Use stack-allocated OidHash in FileHashes and skip expanded hashes on normal runs (#12065) (`677b248`) - test: Port all 8 find-turbo prysk tests to Rust (#12066) (`f827fca`) - fix: Support pnpm per-workspace lockfiles in turbo prune (#12067) (`23d047d`) - test: Port final 2 prysk tests to Rust (100% complete) (#12068) (`6d7e057`) - fix: Resolve Berry prune failure when resolutions contain patch overrides (#12069) (`6fe3c5e`) - test: Add lockfile fixture for yarn berry resolution pruning (issue #2791) (#12071) (`6cc1654`) - chore: Remove prysk test framework entirely (#12070) (`ed2d05a`) - refactor: Clean up test infrastructure and eliminate duplication (#12072) (`338911d`) - fix: Retain injected workspace package entries during pnpm lockfile pruning (#12073) (`acbe869`) - ci: Exclude turborepo-lsp and turborepo-schema-gen from test builds (#12075) (`4ce12e2`) - refactor: Clean up test infrastructure + improve test quality (#12074) (`4571f2b`) - ci: Remove redundant cargo build from coverage job (#12077) (`3c9bbe2`) - perf: Speed up lockfile test suite (#12078) (`20024df`) - ci: Remove integration test serialization (#12079) (`24d7c02`) - fix: Preserve `file:` and `link:` protocol entries in pruned bun lockfile (#12076) (`2635d9a`) - fix: Stop running unnecessary npm install in engines tests (#12081) (`24e4905`) - test: Add lockfile fixture for pnpm v9 injected workspace deps (issue #8243) (#12082) (`4d4929b`) - fix: Filter orphaned Yarn packageExtensions entries during lockfile pruning (#12084) (`68eb223`) - fix: Align experimentalObservability on object maps rather than arrays (#12089) (`9b9d1e4`) - examples: Upgrade with-react-native-web example to use latest versions (#12085) (`980ca43`) - fix: duplicate /signup? in Vercel URL (#12088) (`e865b51`) - ci: Deduplicate Rust test compilation with nextest archive (#12083) (`962cf39`) - fix: Prevent yarn integration tests from hanging on corepack prompts (#12090) (`29b0da7`) - fix: Prevent turbo dev from hanging when daemon file watching fails (#12091) (`b0d2f62`) - ci: Skip pnpm install for Rust test jobs (#12092) (`ebd137f`) - perf: Optimize npm lockfile parser (#12093) (`e4b4a66`) - chore: Trim unused dependency features for faster compilation (#12094) (`03b79e0`) - fix: Prevent lockfile-aware yarn test from hanging on corepack downloads (#12095) (`bf516e4`) - fix: Exclude turborepo-repository from JS smoke test in release workflow (#12097) (`fecc400`) --------- Co-authored-by: Turbobot <turbobot@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two sets of improvements to the Rust integration test suite.
Shared helper refactoring (commit 1)
turbo_command(),git(), andcombined_output()tocommon/mod.rs— single source of truth for turbo binary configuration, git operations, and output mergingturbo_command()replace_turbo_jsonfromstrict_env_vars.rsandrun_summary.rscheck_json_output!macro to useturbo_command()internallywalkdir->find_files_by_name, removes unnecessary_innerwrapperssetup.rsTest quality improvements (commit 2)
edit_turbo_json.rs,run_caching.rs,run_logging.rs. Tests now assert on hash relationships (changed/unchanged) rather than exact hex values. Any hash algorithm change no longer requires updating magic constants.thread::sleep(1s)inrun_summary.rsby sorting summaries by cached count instead of relying on ksuid timestamp ordering. This was a classic flake source.big_status_testfrom 10,000 files to 100. The test proves filenames with spaces are handled correctly — it doesn't need to stress-test I/O.test_single_package_dry_run_pnpm(was only checking exit code).run_caching.rsto sharedcommon::git().22 files changed, ~250 lines removed.