Skip to content

Turbopack: correctly use ChunkGroup::Shared#90978

Merged
mischnic merged 3 commits intocanaryfrom
mischnic/chunk-group-shared-app-router
Mar 9, 2026
Merged

Turbopack: correctly use ChunkGroup::Shared#90978
mischnic merged 3 commits intocanaryfrom
mischnic/chunk-group-shared-app-router

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Mar 6, 2026 •
edited
Loading

I don't think we have any tests that the server utility chunking actually works.
But I can't actually properly remember why we added it in the first place: #70461

@mischnic mischnic mentioned this pull request Mar 6, 2026
Merged
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 6, 2026
@mischnic mischnic mentioned this pull request Mar 6, 2026
Merged
@mischnic Graphite App
Copy link
Member Author

mischnic commented Mar 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing mischnic/chunk-group-shared-app-router (4d1ab99) with canary (b7b58b2)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on canary (99303d3) during the generation of this report, so b7b58b2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 6, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 6, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁█▁▁
Cold (Ready in log) 437ms 438ms ✓ ▂▁█▁▂
Cold (First Request) 1.278s 1.214s ✓ ▄▃█▁▃
Warm (Listen) 456ms 457ms ✓ ▁▁█▁▁
Warm (Ready in log) 443ms 441ms ✓ ▁▁█▁▂
Warm (First Request) 346ms 350ms ✓ ▂▂█▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁██▁
Cold (Ready in log) 439ms 438ms ✓ █▅▆▆▅
Cold (First Request) 1.933s 1.931s ✓ ▅▄▄▄▃
Warm (Listen) 455ms 456ms ✓ █▁███
Warm (Ready in log) 438ms 438ms ✓ ▆▇▇▆█
Warm (First Request) 1.962s 1.938s ✓ ▅▅▅▅▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.794s 3.860s ✓ ▁▁▇▁▃
Cached Build 3.807s 3.815s ✓ ▁▁▇▁▃
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.043s 14.078s ✓ ▂▂▂▂▂
Cached Build 14.151s 14.177s ✓ ▃▂▃▁▂
node_modules Size 477 MB 477 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -17 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 775 B 764 B 🟢 11 B (-1%)
Total 775 B 764 B ✅ -11 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 448 B ✓
Total 451 B 448 B ✅ -3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.3 kB -
Total 233 kB 234 kB ⚠️ +747 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 257 kB ✓
Total 381 kB 382 kB ⚠️ +690 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 615 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.9 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.6 kB 45.3 kB ✅ -225 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.07 MB 4.08 MB 🔴 +8.52 kB (+0%)
index.pack gzip 103 kB 102 kB ✓
index.pack.old gzip 103 kB 105 kB 🔴 +2.01 kB (+2%)
Total 4.28 MB 4.29 MB ⚠️ +9.51 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 319 kB 319 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49.1 kB 49.1 kB ✓
app-route.ru...dev.js gzip 70.5 kB 70.5 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ✅ -2 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/4d1ab99fcd375f808fcf9f94b1fba0c13d8b89f4/next

@mischnic mischnic changed the base branch from mischnic/entry_chunk_group_chunk_group to graphite-base/90978 March 7, 2026 15:39
@mischnic mischnic force-pushed the graphite-base/90978 branch from 0773150 to 99303d3 Compare March 7, 2026 15:39
@mischnic mischnic force-pushed the mischnic/chunk-group-shared-app-router branch from 0bbd5bc to a258361 Compare March 7, 2026 15:39
@graphite-app graphite-app bot changed the base branch from graphite-base/90978 to canary March 7, 2026 15:40
@mischnic mischnic force-pushed the mischnic/chunk-group-shared-app-router branch from a258361 to 4d1ab99 Compare March 7, 2026 15:40
@mischnic mischnic marked this pull request as ready for review March 9, 2026 09:12
@mischnic mischnic merged commit fda324e into canary Mar 9, 2026
163 checks passed
@mischnic mischnic deleted the mischnic/chunk-group-shared-app-router branch March 9, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra sokra approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @nextjs-bot @sokra