Skip to content

Turbopack: pass reference type to CustomModuleType#90814

Merged
mischnic merged 1 commit intocanaryfrom
mischnic/custom-module-type-reference-type
Mar 6, 2026
Merged

Turbopack: pass reference type to CustomModuleType#90814
mischnic merged 1 commit intocanaryfrom
mischnic/custom-module-type-reference-type

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Mar 3, 2026 •
edited
Loading

No reason to restrict it to ReferenceType::EcmaScriptModules(EcmaScriptModulesReferenceSubType::ImportPart(part))

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 3, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Mar 3, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic marked this pull request as ready for review March 3, 2026 10:53
@mischnic mischnic requested a review from sokra March 3, 2026 10:53
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing mischnic/custom-module-type-reference-type (1bd1793) with canary (d08f4dc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

vercel[bot]
vercel bot reviewed Mar 3, 2026
View reviewed changes
@mischnic mischnic force-pushed the mischnic/custom-module-type-reference-type branch from 811a1a2 to 21c1369 Compare March 3, 2026 11:02
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 3, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▅█▁▁▁
Cold (Ready in log) 437ms 439ms ✓ ▄█▁▁▁
Cold (First Request) 1.250s 1.263s ✓ ▃█▁▁▁
Warm (Listen) 456ms 455ms ✓ ▅█▁▁▁
Warm (Ready in log) 440ms 440ms ✓ ▃█▁▁▁
Warm (First Request) 346ms 348ms ✓ ▃█▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ █▁▁▁▁
Cold (Ready in log) 435ms 436ms ✓ █▁▄▆▅
Cold (First Request) 1.928s 1.921s ✓ █▁▃▄▃
Warm (Listen) 456ms 455ms ✓ █▁▁▁▁
Warm (Ready in log) 437ms 436ms ✓ █▁▅▄▃
Warm (First Request) 1.933s 1.930s ✓ █▁▃▃▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.816s 3.699s ✓ ▃█▁▁▁
Cached Build 3.855s 3.762s ✓ ▃█▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.071s 13.989s ✓ █▁▁▁▁
Cached Build 14.111s 14.069s ✓ █▁▁▁▁
node_modules Size 477 MB 477 MB ✓ ██▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ⚠️ +31 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 766 B 767 B ✓
Total 766 B 767 B ⚠️ +1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 446 B 450 B ✓
Total 446 B 450 B ⚠️ +4 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 253 B 🟢 3 B (-1%)
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.2 kB -
Total 233 kB 234 kB ⚠️ +732 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 256 kB ✓
Total 380 kB 381 kB ⚠️ +897 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.5 kB ⚠️ +68 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.06 MB 4.07 MB 🔴 +8.12 kB (+0%)
index.pack gzip 105 kB 103 kB 🟢 1.37 kB (-1%)
index.pack.old gzip 103 kB 104 kB ✓
Total 4.27 MB 4.28 MB ⚠️ +7.46 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route.ru...dev.js gzip 70.4 kB 70.4 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ⚠️ +1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/1bd1793bfd03664841fb178458a8066269beb0ec/next

@mischnic mischnic force-pushed the mischnic/custom-module-type-reference-type branch from 21c1369 to c8049ed Compare March 3, 2026 12:13
@mischnic mischnic mentioned this pull request Mar 3, 2026
Merged
@mischnic mischnic requested a review from a team March 3, 2026 14:08
@mischnic mischnic force-pushed the mischnic/custom-module-type-reference-type branch from c8049ed to 9ef8f44 Compare March 4, 2026 15:47
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 4, 2026 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/custom-module-type-reference-type branch from 9ef8f44 to 1bd1793 Compare March 6, 2026 10:30
@mischnic mischnic merged commit 07df7fa into canary Mar 6, 2026
284 of 288 checks passed
@mischnic mischnic deleted the mischnic/custom-module-type-reference-type branch March 6, 2026 11:19
@mischnic mischnic mentioned this pull request Mar 6, 2026
Merged
sokra pushed a commit that referenced this pull request Mar 6, 2026
@mischnic @sokra
Turbopack: pass reference type to CustomModuleType (#90814)
c528ecf 
No reason to restrict it to `ReferenceType::EcmaScriptModules(EcmaScriptModulesReferenceSubType::ImportPart(part))`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@lukesandberg lukesandberg lukesandberg approved these changes

@sokra sokra Awaiting requested review from sokra

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @nextjs-bot @lukesandberg