Skip to content

fix(cache): DCE to avoid pulling server internals into browser bundles (4/8)#89865

Merged
timneutkens merged 2 commits intocanaryfrom
feedthejim/node-stream-01d-cache-dce
Feb 19, 2026
Merged

fix(cache): DCE to avoid pulling server internals into browser bundles (4/8)#89865
timneutkens merged 2 commits intocanaryfrom
feedthejim/node-stream-01d-cache-dce

Conversation

@feedthejim
Copy link
Copy Markdown
Contributor

@feedthejim feedthejim commented Feb 11, 2026 •
edited
Loading

Summary

Fix dead-code elimination in packages/next/cache.js to prevent server-only internals from being pulled into browser bundles. Restructures the conditional exports so bundlers can properly tree-shake server paths.

Test plan

  • pnpm --filter=next build succeeds
  • No runtime behavior changes

This was referenced Feb 11, 2026
Merged
Merged
Draft
Draft
Merged
@feedthejim Graphite App
Copy link
Copy Markdown
Contributor Author

feedthejim commented Feb 11, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 11, 2026
Merged
Merged
@feedthejim feedthejim force-pushed the feedthejim/node-stream-01c-fixes branch from 4e5afea to ab734ba Compare February 11, 2026 22:34
@feedthejim feedthejim force-pushed the feedthejim/node-stream-01d-cache-dce branch from b5ee83a to a174fe1 Compare February 11, 2026 22:34
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 11, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 439ms 440ms ✓ ▂▁▂▁▁
Cold (First Request) 1.268s 1.255s ✓ ▄▃▄▁▄
Warm (Listen) 456ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 444ms 443ms ✓ ▁▁▁▁▁
Warm (First Request) 353ms 348ms ✓ ▁▂▁▂▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▄█▁
Cold (Ready in log) 440ms 439ms ✓ ▂▃▂█▂
Cold (First Request) 1.934s 1.953s ✓ ▁▂▂█▁
Warm (Listen) 455ms 456ms ✓ ▁▁▄█▁
Warm (Ready in log) 440ms 439ms ✓ ▃▃▁█▂
Warm (First Request) 1.973s 1.973s ✓ ▁▁▁█▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.891s 3.937s ✓ ▁▁▁▃▁
Cached Build 4.053s 4.023s ✓ ▁▁▁▃▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.024s 14.080s ✓ ▁▁▂█▁
Cached Build 14.259s 14.239s ✓ ▁▁▁█▁
node_modules Size 473 MB 473 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **398 kB** → **398 kB** ✅ -8 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 760 B 763 B ✓
Total 760 B 763 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 451 B ✓
Total 451 B 451 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57.2 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 57.9 kB -
Total 231 kB 231 kB ⚠️ +716 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.5 kB 2.5 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 252 kB 252 kB ✓
Total 376 kB 376 kB ✅ -77 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.4 kB 43.8 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45 kB 45.4 kB ⚠️ +382 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 3.92 MB 3.93 MB 🔴 +6.56 kB (+0%)
index.pack gzip 105 kB 104 kB 🟢 1.16 kB (-1%)
index.pack.old gzip 103 kB 104 kB 🔴 +1.19 kB (+1%)
Total 4.13 MB 4.13 MB ⚠️ +6.59 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 317 kB 317 kB ✓
app-page-exp..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 316 kB 316 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 313 kB 313 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page.run...dev.js gzip 313 kB 313 kB ✓
app-page.run..prod.js gzip 167 kB 167 kB ✓
app-route-ex...dev.js gzip 70.6 kB 70.6 kB ✓
app-route-ex..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.6 kB 70.6 kB ✓
app-route-tu..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.2 kB 70.2 kB ✓
app-route-tu..prod.js gzip 48.9 kB 48.9 kB ✓
app-route.ru...dev.js gzip 70.2 kB 70.2 kB ✓
app-route.ru..prod.js gzip 48.9 kB 48.9 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 38.4 kB 38.4 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 38.4 kB 38.4 kB ✓
server.runti..prod.js gzip 63.6 kB 63.6 kB ✓
Total 2.8 MB 2.8 MB ✅ -1 B

@feedthejim feedthejim changed the title fix(cache): DCE to avoid pulling server internals into browser bundles (4/8) fix(cache): DCE to avoid pulling server internals into browser bundles Feb 12, 2026
@feedthejim feedthejim changed the title (4/8) fix(cache): DCE to avoid pulling server internals into browser bundles fix(cache): DCE to avoid pulling server internals into browser bundles (4/8) Feb 12, 2026
@timneutkens timneutkens mentioned this pull request Feb 13, 2026
Closed
@timneutkens timneutkens force-pushed the feedthejim/node-stream-01c-fixes branch from ab734ba to ab5300e Compare February 16, 2026 14:59
@timneutkens timneutkens force-pushed the feedthejim/node-stream-01d-cache-dce branch 2 times, most recently from 24732c7 to a296e79 Compare February 16, 2026 16:50
@timneutkens timneutkens force-pushed the feedthejim/node-stream-01c-fixes branch from ab5300e to 38a8b92 Compare February 16, 2026 16:50
@timneutkens timneutkens marked this pull request as ready for review February 16, 2026 16:51
unstubbable
unstubbable reviewed Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extend the example app in test/production/app-dir/browser-chunks to catch this? Under which circumstances do these modules even end up in the browser chunks?

@timneutkens timneutkens force-pushed the feedthejim/node-stream-01d-cache-dce branch from a296e79 to 74b6486 Compare February 19, 2026 10:20
@timneutkens timneutkens force-pushed the feedthejim/node-stream-01c-fixes branch from 38a8b92 to abd151e Compare February 19, 2026 10:20
Base automatically changed from feedthejim/node-stream-01c-fixes to canary February 19, 2026 11:06
@timneutkens timneutkens force-pushed the feedthejim/node-stream-01d-cache-dce branch from 74b6486 to f0c9ffe Compare February 19, 2026 11:07
@timneutkens
Copy link
Copy Markdown
Member

timneutkens commented Feb 19, 2026

@unstubbable I asked Claude to write a test case for this. Seems the specific case is that we allow unstable_cache in client components... maybe that shouldn't be allowed in the first place? Given that it's noop function in that context.

@timneutkens timneutkens merged commit cf83d7c into canary Feb 19, 2026
158 checks passed
@timneutkens timneutkens deleted the feedthejim/node-stream-01d-cache-dce branch February 19, 2026 12:36
@github-actions github-actions bot added the locked label Mar 6, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@unstubbable unstubbable unstubbable left review comments

@timneutkens timneutkens timneutkens approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@feedthejim @nextjs-bot @timneutkens @unstubbable