Reuse cached loading segment data when loading state is re-triggered#62347
Closed
ztanner wants to merge 2 commits into02-21-Store_loading_data_in_CacheNodefrom
Closed
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Tests Passed |
d163e25 to
c3d336c
Compare
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| buildDuration | 13.8s | 13.9s | N/A |
| buildDurationCached | 8.4s | 6.3s | N/A |
| nodeModulesSize | 198 MB | 198 MB | |
| nextStartRea..uration (ms) | 430ms | 437ms | N/A |
Client Bundles (main, webpack) Overall increase ⚠️
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| 2453-HASH.js gzip | 30.5 kB | 30.8 kB | |
| 3304.HASH.js gzip | 181 B | 181 B | ✓ |
| 3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | N/A |
| 8299-HASH.js gzip | 5.04 kB | 5.04 kB | N/A |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 242 B | 241 B | N/A |
| main-HASH.js gzip | 32.2 kB | 32.2 kB | N/A |
| webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
| Overall change | 75.9 kB | 76.1 kB |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 197 B | N/A |
| _error-HASH.js gzip | 184 B | 184 B | ✓ |
| amp-HASH.js gzip | 505 B | 505 B | ✓ |
| css-HASH.js gzip | 324 B | 325 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
| head-HASH.js gzip | 352 B | 352 B | ✓ |
| hooks-HASH.js gzip | 370 B | 371 B | N/A |
| image-HASH.js gzip | 4.21 kB | 4.21 kB | ✓ |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 6.57 kB | 6.57 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 481 B | 484 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| index.html gzip | 529 B | 528 B | N/A |
| link.html gzip | 541 B | 542 B | N/A |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 95.1 kB | 95.1 kB | N/A |
| page.js gzip | 3.06 kB | 3.07 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 625 B | 624 B | N/A |
| middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
| middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 990 B | 990 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 171 kB | 171 kB | N/A |
| app-page-exp..prod.js gzip | 96.5 kB | 96.5 kB | N/A |
| app-page-tur..prod.js gzip | 98.2 kB | 98.2 kB | N/A |
| app-page-tur..prod.js gzip | 92.7 kB | 92.7 kB | N/A |
| app-page.run...dev.js gzip | 149 kB | 149 kB | N/A |
| app-page.run..prod.js gzip | 91.2 kB | 91.2 kB | N/A |
| app-route-ex...dev.js gzip | 21.3 kB | 21.3 kB | ✓ |
| app-route-ex..prod.js gzip | 15 kB | 15 kB | ✓ |
| app-route-tu..prod.js gzip | 15 kB | 15 kB | ✓ |
| app-route-tu..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
| app-route.ru...dev.js gzip | 20.9 kB | 20.9 kB | ✓ |
| app-route.ru..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.52 kB | 9.52 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.8 kB | 9.8 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.52 kB | 9.52 kB | ✓ |
| pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| pages.runtim...dev.js gzip | 22.9 kB | 22.9 kB | ✓ |
| pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| server.runti..prod.js gzip | 50.5 kB | 50.5 kB | ✓ |
| Overall change | 249 kB | 249 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js 02-21-Expire_loading_state_cache_separately_from_cache_node_data | Change | |
|---|---|---|---|
| 0.pack gzip | 1.56 MB | 1.56 MB | N/A |
| index.pack gzip | 105 kB | 105 kB | |
| Overall change | 105 kB | 105 kB |
Diff details
Diff for middleware.js
Diff too large to display
Diff for 2453-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
Diff too large to display
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
Diff too large to display
Diff for app-page.runtime.prod.js
Diff too large to display
bed24f1 to
296e046
Compare
d97505e to
f53e3e1
Compare
eb48100 to
1c7b81e
Compare
a1a0542 to
cf900a2
Compare
db8eaaf to
22c00ad
Compare
efb59e7 to
964927d
Compare
22c00ad to
edccdea
Compare
964927d to
ff5bc7d
Compare
edccdea to
ff8cb80
Compare
ff5bc7d to
af906b6
Compare
8dc5c21 to
9200fd8
Compare
ff8cb80 to
4f7e581
Compare
0d8d595 to
75e12b3
Compare
4f7e581 to
3540b25
Compare
75e12b3 to
5136504
Compare
3540b25 to
4d9b44f
Compare
5136504 to
4399b02
Compare
4d9b44f to
1be6d1b
Compare
4399b02 to
bb6a4c5
Compare
1be6d1b to
9c738c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the test that was disabled in #61573 by implementing the behavior differently. Previously we would "partially" expire the prefetch cache and reuse the loading data from the stale prefetch.
Now that we no longer re-use stale prefetch data, this PR instead updates the logic to re-use the existing cache node's
loading. Since the PR that this is stacked upon has moved all loading data to be part of the cache node seed data, we can copy over the existing entry when navigating.Closes NEXT-2558