Skip to content

Pass whole prefetch entry rather than status property#62345

Merged
ztanner merged 1 commit intocanaryfrom
02-21-Pass_whole_prefetch_entry_rather_than_status_property
Mar 7, 2024
Merged

Pass whole prefetch entry rather than status property#62345
ztanner merged 1 commit intocanaryfrom
02-21-Pass_whole_prefetch_entry_rather_than_status_property

Conversation

@ztanner
Copy link
Member

@ztanner ztanner commented Feb 21, 2024 •
edited
Loading

No change in behavior -- this PR updates applyFlightData and its recursive functions to receive the prefetch entry rather than a boolean. We only use the actual prefetch entry in fillLazyItemsTillLeafWithHead but I found kept getting confused about what this argument was needed for when it was provided so far away from the part where we read the boolean.

Closes NEXT-2556

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 21, 2024
@ztanner Graphite App
Copy link
Member Author

ztanner commented Feb 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite Graphite

This was referenced Feb 21, 2024
Merged
Closed
@ztanner ztanner force-pushed the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch 2 times, most recently from 372be9e to 20eb139 Compare February 21, 2024 21:08
@ijjk
Copy link
Member

ijjk commented Feb 21, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
buildDuration 13.8s 13.9s N/A
buildDurationCached 7.5s 6.3s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 434ms 435ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 244 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.56 kB 6.56 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
index.html gzip 529 B 529 B ✓
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.59 kB 1.59 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
edge-ssr.js gzip 95 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
middleware-b..fest.js gzip 623 B 623 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 1.61 kB 1.61 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 96.7 kB 96.7 kB ✓
app-page-tur..prod.js gzip 98.5 kB 98.5 kB ✓
app-page-tur..prod.js gzip 92.9 kB 92.9 kB ✓
app-page.run...dev.js gzip 149 kB 149 kB ✓
app-page.run..prod.js gzip 91.4 kB 91.4 kB ✓
app-route-ex...dev.js gzip 21.3 kB 21.3 kB ✓
app-route-ex..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 21 kB 21 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB ✓
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB ✓
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.6 kB 50.6 kB ✓
Overall change 949 kB 949 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-21-Pass_whole_prefetch_entry_rather_than_status_property Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +1.11 kB
index.pack gzip 105 kB 105 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +1.11 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Commit: be82a9d

@ztanner ztanner force-pushed the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch from 20eb139 to b735632 Compare February 22, 2024 06:07
@ijjk
Copy link
Member

ijjk commented Feb 22, 2024 •
edited
Loading

Tests Passed

@ztanner ztanner marked this pull request as ready for review February 22, 2024 07:07
@ztanner ztanner force-pushed the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch 2 times, most recently from c09003d to a4761d8 Compare March 4, 2024 23:02
@ztanner ztanner mentioned this pull request Mar 5, 2024
Merged
@ztanner ztanner force-pushed the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch 2 times, most recently from 42cbd36 to fbf9831 Compare March 5, 2024 22:23
@ztanner ztanner force-pushed the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch from fbf9831 to be82a9d Compare March 7, 2024 00:21
@ztanner ztanner merged commit b580b87 into canary Mar 7, 2024
@ztanner ztanner deleted the 02-21-Pass_whole_prefetch_entry_rather_than_status_property branch March 7, 2024 01:14
@ztanner ztanner mentioned this pull request Mar 13, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ztanner @ijjk