Skip to content

fix (ai/core): filter out empty content/text assistant messages#5767

Merged
lgrammel merged 4 commits intovercel:mainfrom
iteratetograceness:to-resp-msgs
Apr 15, 2025
Merged

fix (ai/core): filter out empty content/text assistant messages#5767
lgrammel merged 4 commits intovercel:mainfrom
iteratetograceness:to-resp-msgs

Conversation

@iteratetograceness
Copy link
Copy Markdown
Contributor

Background

Addresses #5576

Summary

Refactors logic in toResponseMessages util to:

  • only append text content object when text is defined and not an empty string
  • only append message if the content array length is > 0

Tasks

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If required, a patch changeset for relevant packages has been added
  • You've run pnpm prettier-fix to fix any formatting issues

@lgrammel lgrammel changed the title fix: empty content/text assistant messages fix (ai/core): filter out empty content/text assistant messages Apr 15, 2025
@lgrammel lgrammel merged commit f4f3945 into vercel:main Apr 15, 2025
6 of 7 checks passed
lgrammel added a commit that referenced this pull request Apr 15, 2025
… (#5783)

Co-authored-by: Grace Yun <74513600+iteratetograceness@users.noreply.github.com>
samdenty pushed a commit that referenced this pull request Apr 15, 2025
* origin/v5: (36 commits)
  fix (provider): remove deprecated `Experimental_LanguageModelV2Middleware` (#5775)
  fix (ai): remove deprecated `options.throwErrorForEmptyVectors` from `cosineSimilarity()` (#5772)
  fix (ai/core): filter out empty content/text assistant messages (#5767) (#5783)
  fix (ai): remove deprecated `CoreTool*` types (#5768)
  chore: refactor text parts (spec) (#5759)
  feat(embedding-model-v2): add response body field (#5700)
  feat(embedding-model-v2): add providerOptions (#5698)
  chore: refactor reasoning parts (spec) (#5756)
  chore: update .gitignore (#5755)
  chore: refactor source parts (spec) (#5753)
  chore: refactor file parts (spec) (#5750)
  chore: refactor tool call and tool call delta parts (spec) (#5746)
  fix(providers/xai): edit supported models for structured output (#5715) (#5741)
  chore (ai): remove provider re-exports (#5734)
  chore (provider): extract shared provider options and metadata (spec) (#5733)
  fix(ai/core): properly handle custom separator in provider registry (#5713) (#5732)
  chore (providers/xai): update grok-3 model aliases (#5646)
  chore(embedding-model-v2): rename rawResponse to response (#5699)
  chore(providers/mistral): convert to providerOptions (#5675)
  chore: refactor file towards source pattern (spec) (#5709)
  ...
samdenty pushed a commit that referenced this pull request Apr 15, 2025
…der-options

* origin/v5: (36 commits)
  fix (provider): remove deprecated `Experimental_LanguageModelV2Middleware` (#5775)
  fix (ai): remove deprecated `options.throwErrorForEmptyVectors` from `cosineSimilarity()` (#5772)
  fix (ai/core): filter out empty content/text assistant messages (#5767) (#5783)
  fix (ai): remove deprecated `CoreTool*` types (#5768)
  chore: refactor text parts (spec) (#5759)
  feat(embedding-model-v2): add response body field (#5700)
  feat(embedding-model-v2): add providerOptions (#5698)
  chore: refactor reasoning parts (spec) (#5756)
  chore: update .gitignore (#5755)
  chore: refactor source parts (spec) (#5753)
  chore: refactor file parts (spec) (#5750)
  chore: refactor tool call and tool call delta parts (spec) (#5746)
  fix(providers/xai): edit supported models for structured output (#5715) (#5741)
  chore (ai): remove provider re-exports (#5734)
  chore (provider): extract shared provider options and metadata (spec) (#5733)
  fix(ai/core): properly handle custom separator in provider registry (#5713) (#5732)
  chore (providers/xai): update grok-3 model aliases (#5646)
  chore(embedding-model-v2): rename rawResponse to response (#5699)
  chore(providers/mistral): convert to providerOptions (#5675)
  chore: refactor file towards source pattern (spec) (#5709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants