feat(embedding-model-v2): add response body field#5700
Merged
Conversation
lgrammel
reviewed
Apr 12, 2025
Collaborator
|
Is |
Contributor
Author
|
@lgrammel just added tests :) |
lgrammel
reviewed
Apr 12, 2025
| /** | ||
| Optional raw response data. | ||
| */ | ||
| readonly rawResponses?: Array< |
Collaborator
There was a problem hiding this comment.
Nice - should be eventually renamed to responses once the rename PR lands.
Collaborator
There was a problem hiding this comment.
is this similar to what we do for transcribe?
Contributor
Author
There was a problem hiding this comment.
Yep, just checked they use the same pattern:
https://github.com/vercel/ai/blob/main/packages/ai/core/transcribe/transcribe-result.ts#L51C1-L54C65
Collaborator
|
Will revisit after #5699 lands bc of the dependency |
Contributor
Author
|
@lgrammel updated the PR to use the new responses field instead of rawResponses |
Collaborator
|
Can you split into 2 PRs, one for adding |
5d33842 to
88dc1d4
Compare
lgrammel
reviewed
Apr 14, 2025
lgrammel
reviewed
Apr 14, 2025
lgrammel
reviewed
Apr 14, 2025
lgrammel
reviewed
Apr 14, 2025
packages/google/src/google-generative-ai-embedding-model.test.ts
Outdated
Show resolved
Hide resolved
lgrammel
reviewed
Apr 14, 2025
packages/google-vertex/src/google-vertex-embedding-model.test.ts
Outdated
Show resolved
Hide resolved
lgrammel
reviewed
Apr 14, 2025
lgrammel
reviewed
Apr 14, 2025
bae298f to
7ebd602
Compare
lgrammel
reviewed
Apr 14, 2025
lgrammel
approved these changes
Apr 14, 2025
samdenty
pushed a commit
that referenced
this pull request
Apr 15, 2025
* origin/v5: (36 commits) fix (provider): remove deprecated `Experimental_LanguageModelV2Middleware` (#5775) fix (ai): remove deprecated `options.throwErrorForEmptyVectors` from `cosineSimilarity()` (#5772) fix (ai/core): filter out empty content/text assistant messages (#5767) (#5783) fix (ai): remove deprecated `CoreTool*` types (#5768) chore: refactor text parts (spec) (#5759) feat(embedding-model-v2): add response body field (#5700) feat(embedding-model-v2): add providerOptions (#5698) chore: refactor reasoning parts (spec) (#5756) chore: update .gitignore (#5755) chore: refactor source parts (spec) (#5753) chore: refactor file parts (spec) (#5750) chore: refactor tool call and tool call delta parts (spec) (#5746) fix(providers/xai): edit supported models for structured output (#5715) (#5741) chore (ai): remove provider re-exports (#5734) chore (provider): extract shared provider options and metadata (spec) (#5733) fix(ai/core): properly handle custom separator in provider registry (#5713) (#5732) chore (providers/xai): update grok-3 model aliases (#5646) chore(embedding-model-v2): rename rawResponse to response (#5699) chore(providers/mistral): convert to providerOptions (#5675) chore: refactor file towards source pattern (spec) (#5709) ...
samdenty
pushed a commit
that referenced
this pull request
Apr 15, 2025
…der-options * origin/v5: (36 commits) fix (provider): remove deprecated `Experimental_LanguageModelV2Middleware` (#5775) fix (ai): remove deprecated `options.throwErrorForEmptyVectors` from `cosineSimilarity()` (#5772) fix (ai/core): filter out empty content/text assistant messages (#5767) (#5783) fix (ai): remove deprecated `CoreTool*` types (#5768) chore: refactor text parts (spec) (#5759) feat(embedding-model-v2): add response body field (#5700) feat(embedding-model-v2): add providerOptions (#5698) chore: refactor reasoning parts (spec) (#5756) chore: update .gitignore (#5755) chore: refactor source parts (spec) (#5753) chore: refactor file parts (spec) (#5750) chore: refactor tool call and tool call delta parts (spec) (#5746) fix(providers/xai): edit supported models for structured output (#5715) (#5741) chore (ai): remove provider re-exports (#5734) chore (provider): extract shared provider options and metadata (spec) (#5733) fix(ai/core): properly handle custom separator in provider registry (#5713) (#5732) chore (providers/xai): update grok-3 model aliases (#5646) chore(embedding-model-v2): rename rawResponse to response (#5699) chore(providers/mistral): convert to providerOptions (#5675) chore: refactor file towards source pattern (spec) (#5709) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Summary
This adds a response body field to embedding model v2
Tasks
pnpm prettier-fixto fix any formatting issuesFuture Work