fix: fix handling of null values in stringValue#4127
Merged
Conversation
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Deploying vega with
|
| Latest commit: |
c29a475
|
| Status: | 🚫 Build failed. |
Merged
lsh
added a commit
that referenced
this pull request
Sep 16, 2025
Changes since v6.1.2 **monorepo**: * Use blazediff to speed up visual diffs (thanks @teimurjan!) (via #4125) * Update version in specs (thanks @domoritz!) (via #4045) **vega**: * Export schema from Vega package (thanks @domoritz!) (via #4046) **vega-loader**: * Correct mode handling in loader (thanks @domoritz!) (via #4048) **vega-util**: * Fix handling of null values in stringValue (thanks @domoritz!) (via #4127) * Replace all problematic Unicode characters (thanks @basbroek!) (via #4130) **docs**: * Update links to Prefuse and Protovis (thanks @star1327p!) (via #4095) * Replace version in specs (thanks @domoritz!) (via #4085) * Update file name in weather example (thanks @domoritz!) (via #4083) * Update versions in docs (thanks @domoritz!) (via #4050) * Update of the labelled donut example (thanks @PBI-David!) (via #4064) * Addition of the labelled donut example (thanks @PBI-David!) (via #4062) --------- Signed-off-by: Lukas Hermann <1734032+lsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version ignored null values in arrays, which caused issues in Vega-Lite. See vega/vega-lite#9683