feat: use blazediff to speed up visual diffs#4125
Conversation
domoritz
left a comment
There was a problem hiding this comment.
Thanks for the pull request. I'm usually hesitant to change development dependencies unless there is an issue that they fix but your library looks pretty nice. I'll say though, that I expect you to maintain in over the coming years or we will need to switch back to Pixelmatch.
I was wondering, why don't you upstream your improvements to pixelmatch instead of making a new library? I'm specifically talking about the perf improvements not so much the package setup.
|
Hey @domoritz! Thanks for a warm comment. Yes, I will maintain the current features, add new ones, and work towards library improvements. I have lots of ideas to make it even faster. I could add my block-based optimization to Firstly, I introduced the concept of transformers, which enable reading and writing images in a format/size/platform. For instance, the next iteration for your package would be trying out All these ideas would be too much for You can rely on my package and my support. I want to grow it :) |
Changes since v6.1.2 **monorepo**: * Use blazediff to speed up visual diffs (thanks @teimurjan!) (via #4125) * Update version in specs (thanks @domoritz!) (via #4045) **vega**: * Export schema from Vega package (thanks @domoritz!) (via #4046) **vega-loader**: * Correct mode handling in loader (thanks @domoritz!) (via #4048) **vega-util**: * Fix handling of null values in stringValue (thanks @domoritz!) (via #4127) * Replace all problematic Unicode characters (thanks @basbroek!) (via #4130) **docs**: * Update links to Prefuse and Protovis (thanks @star1327p!) (via #4095) * Replace version in specs (thanks @domoritz!) (via #4085) * Update file name in weather example (thanks @domoritz!) (via #4083) * Update versions in docs (thanks @domoritz!) (via #4050) * Update of the labelled donut example (thanks @PBI-David!) (via #4064) * Addition of the labelled donut example (thanks @PBI-David!) (via #4062) --------- Signed-off-by: Lukas Hermann <1734032+lsh@users.noreply.github.com>
Description
Replace pixelmatch with BlazeDiff. BlazeDiff is 20-25% faster than pixelmatch, using the same API and producing the same results. It weighs 2 times less, is actively supported, and type-safe out of the box.
Benchmarks