Skip to content

docs: Replace redirect url in expressions.md#3996

Merged
dangotbanned merged 6 commits intomainfrom
docs-replace-sample-uniform
Feb 1, 2025
Merged

docs: Replace redirect url in expressions.md#3996
dangotbanned merged 6 commits intomainfrom
docs-replace-sample-uniform

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Jan 2, 2025 •
edited
Loading

Related vega/altair#3699 (comment)

This PR provides an upstream fix for altair when parsing this URL for alt.expr.sampleUniform.

Both links reach the same page, but @jonmmease discovered the current one got mangled during parsing.

I came across the code added to fix this in (vega/altair@4433faa) and I'm hoping to clean it up as per (vega/altair#3687 (comment))

Tracking

@dangotbanned
docs: Replace redirect url in expressions.md
ae5f389 
Related vega/altair#3699 (comment)

This PR provides an upstream fix for `altair` when parsing this URL for [`alt.expr.sampleUniform`](https://altair-viz.github.io/user_guide/generated/api-cls/altair.expr.html#altair.expr).

Both links reach the same page, but @jonmmease discovered the current one got mangled during parsing.

- [Current URL](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous))
- [Replacement URL](https://en.wikipedia.org/wiki/Continuous_uniform_distribution)
@dangotbanned dangotbanned added the documentation For documentation-related issues label Jan 2, 2025
@dangotbanned dangotbanned requested a review from a team as a code owner January 2, 2025 16:51
@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Jan 2, 2025 •
edited
Loading

I'll be honest, I have no clue what is going on here (https://github.com/vega/vega/actions/runs/12585813958/job/35078386333?pr=3996)

Tried to build the project locally, but got tripped up by this seemingly conflicting with (#3915):

vega/package.json

Lines 59 to 61 in f43b21f

"engines": {
"node": ">=18.18.0"
},

Seemed to have worked around that locally - but still struggling to get much working (https://github.com/vega/vega/#build-instructions)

@dangotbanned dangotbanned mentioned this pull request Jan 2, 2025
Merged
@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Jan 2, 2025

@domoritz FYI, the failures seem to be unrelated to this PR.

I approved these runs and they failed as well:

@dangotbanned dangotbanned mentioned this pull request Jan 7, 2025
Open
domoritz
domoritz requested changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@domoritz domoritz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. There are a bunch more places with the old url that we should replace. Can you make a full pass searching for https://en.wikipedia.org/wiki/Uniform_distribution_?

@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Jan 9, 2025

Thanks for the pull request. There are a bunch more places with the old url that we should replace. Can you make a full pass searching for https://en.wikipedia.org/wiki/Uniform_distribution_?

Sure @domoritz, will have a look tomorrow

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 9, 2025 •
edited
Loading

Deploying vega with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a25ef2
Status: ✅  Deploy successful!
Preview URL: https://8f3092a1.vega-628.pages.dev
Branch Preview URL: https://docs-replace-sample-uniform.vega-628.pages.dev

View logs

@dangotbanned dangotbanned requested a review from domoritz January 9, 2025 09:56
@dangotbanned dangotbanned mentioned this pull request Jan 14, 2025
Open
@dangotbanned dangotbanned removed the request for review from domoritz January 24, 2025 18:56
@dangotbanned dangotbanned requested review from a team and domoritz January 24, 2025 18:56
@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Jan 28, 2025

@jonmmease No rush, but could you take a look at this PR before https://github.com/vega/vl-convert/releases/tag/v1.80?

Ideally I'd want the next time altair bumps vl-convert to have:

Tip

Remember to check NOTES_FOR_MAINTAINERS.md#updating-vega-versions for the updated-update process 🙂

@dangotbanned dangotbanned enabled auto-merge (squash) February 1, 2025 20:10
@dangotbanned dangotbanned merged commit b83b8e5 into main Feb 1, 2025
@dangotbanned dangotbanned deleted the docs-replace-sample-uniform branch February 1, 2025 20:12
@lsh lsh mentioned this pull request Feb 24, 2025
Merged
lsh added a commit that referenced this pull request Feb 25, 2025
@lsh
chore: v5.32.0 (#4014)
2fe2e63 
Changes since v5.31.0

**vega-expression**
* Add base64 string encoder/decoder to `vega-expression` and
`vega-interpreter` (via #4009). (Thanks @hydrosquall!)

**vega-typings**
* Add Typescript Types for `vega-loader` (via #4000). (Thanks
@hydrosquall!)

**docs**
* Correct data year citation in dorling-cartogram example (via #4006).
(Thanks @dsmedia!)
* Update typo in vega.timeFloor description (via #4010). (Thanks
@hydrosquall!)
* Add Security Advisory Policy for Vega (via #4008). (Thanks
@hydrosquall!)
* Replace redirect url in `expressions.md` (via #3996). (Thanks
@dangotbanned!)
* correct queries to query in `crossfilter.md` (via #4005). (Thanks
@danmarshall!)

---------

Signed-off-by: Lukas Hermann <1734032+lsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domoritz domoritz domoritz approved these changes

Assignees

No one assigned

Labels

documentation For documentation-related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dangotbanned @domoritz