test: replace flights-5k.json external reference#3999
Merged
dangotbanned merged 1 commit intovega:mainfrom Jan 14, 2025
Merged
Conversation
flights-5k.json external reference
dangotbanned
approved these changes
Jan 14, 2025
Member
dangotbanned
left a comment
There was a problem hiding this comment.
Thanks for fixing this @dwootton
I'll leave this open until the end of the day, in case anyone from (#3998 (comment)) has any feedback
1 task
Merged
lsh
added a commit
that referenced
this pull request
Jan 24, 2025
changes since v5.30.0 **vega-utils** * use `Object.hasOwn` instead of `Object.prototype.hasOwnProperty` (via #3951). (Thanks @domoritz!) **vega-parser** * Add discrete legend type (via #3957). (Thanks @hydrosquall!) **vega-functions** * Add sort function to vega-functions (and vega-interpreter) (via #3973). (Thanks @hydrosquall!) **vega-selections** * Add field predicate types to selectionTest (via #3675). (Thanks @jonathanzong!) **monorepo** * Replace flights-5k.json external reference (via #3999). (Thanks @dwootton!) **docs** * Update packed bubble example (via #3955). (Thanks @PBI-David!) * Correct typo in production rules documentation (via #3958). (Thanks @shanebruggeman!) * Update README.md to fix broken link to current roadmap (via #3979). (Thanks @cahogan & @joelostblom!) --------- Signed-off-by: Lukas Hermann <1734032+lsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a previous issue with one of our tests referencing an external dataset in vega_datasets. I've updated the spec to reference the same dataset but as a local copy such that the test doesn't fail if the external dataset gets updated.