Conversation
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Deploying vega with
|
| Latest commit: |
752d4ac
|
| Status: | 🚫 Build failed. |
|
Why not use |
|
|
domoritz
left a comment
There was a problem hiding this comment.
Looks like these are all within bumps except one.
| "vega-time": "~2.1.1", | ||
| "vega-transforms": "~4.11.1", | ||
| "vega-typings": "~1.1.0", | ||
| "vega-typings": "~1.3.0", |
There was a problem hiding this comment.
This seems to be the only non automatic version bump.
|
I wonder if |
There was a problem hiding this comment.
This is a good first step, thanks for taking this on. Commenting to note that for every package that had its version changed, that package will also need to have a new version. (For example vega-functions was at 5.14.0 before this change. Upgrading the versions will cause a version bump for it, maybe 5.14.1.
Unfortunately, that will cause packages that reference vega-functions (like vega-view) to need to bump which copy of vega-function they're importing too.
The amount of churn here can be limited by running the upgrade in topological sort order (so that leaves are bumped first like vega-util, and roots like vega-view get bumped last.
To keep this already large change low risk, we could avoid the d3- deps, and just do the vega- ones in this PR. However, if we feel confident in all the d3-bumps, feel free to leave the change as is.
## Motivation - Repeat vega/vega-lite#9362, but for vega repo instead of vega-lite. Build broke after we changed from vite back to parcel - Noticed build preview was failing for a recent PR for reasons unrelated to that change ( #3930 (comment) ) ## Changes - Update the build command to match what we have in vega-lite (remove the dependency on vite) ## Testing The cloudflare deploy preview should succeed on this branch (watch for comment)
Take two on #3930. Using @hydrosquall's diagram on the topological sort to try and bump things in order. --------- Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
|
Closed in favor of #3932 |
The goal of this PR is to reduce out of date interdependencies in the workspace. I basically just went through and ran
ncu -uiin each folder, and updated any minor or patch versions. The only project where this didn't work is invega-typings, which has some issues related to the ts-schema-generator that we can look into later (and are semi-unrelated to the goal of this PR anyway).