Skip to content

fix: repair deploy editor preview for vega#3931

Merged
hydrosquall merged 1 commit intomainfrom
cameron.yick/fix-deploy-previews-vite-vega
Jun 12, 2024
Merged

fix: repair deploy editor preview for vega#3931
hydrosquall merged 1 commit intomainfrom
cameron.yick/fix-deploy-previews-vite-vega

Conversation

@hydrosquall
Copy link
Copy Markdown
Member

@hydrosquall hydrosquall commented Jun 11, 2024

Motivation

Changes

  • Update the build command to match what we have in vega-lite (remove the dependency on vite)

Testing

The cloudflare deploy preview should succeed on this branch (watch for comment)

@hydrosquall hydrosquall self-assigned this Jun 11, 2024
@hydrosquall hydrosquall requested a review from a team as a code owner June 11, 2024 23:56
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying vega with  Cloudflare Pages  Cloudflare Pages

Latest commit: 65df0fb
Status: ✅  Deploy successful!
Preview URL: https://8757645a.vega-628.pages.dev
Branch Preview URL: https://cameron-yick-fix-deploy-prev.vega-628.pages.dev

View logs

@hydrosquall hydrosquall merged commit a69f039 into main Jun 12, 2024
@hydrosquall hydrosquall deleted the cameron.yick/fix-deploy-previews-vite-vega branch June 12, 2024 12:46
@lsh lsh mentioned this pull request Jun 13, 2024
lsh pushed a commit that referenced this pull request Jun 14, 2024
Changes since v5.29.0

**vega-functions**
- make default vega format null as "null" (via #3926). (Thanks @kanitw &
@domoritz )!

**docs**
- Add 4 new examples (via #3851). (Thanks @avatorl & @domoritz!)

**monorepo**
- Deploy editor preview (via #3925, #3931). (Thanks @hydrosquall!)
- Bump all `vega-*` deps in topological order to eliminate version
mismatches within the monorepo (via #3932). (Thanks @lsh!)

Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants