Add epoch information to failover auth denied logs#816
Merged
Conversation
When failover deny to vote, sometimes due to network or some blocking operations, the time of FAILOVER_AUTH_REQUEST packet arrival is very uncertain. Since there is no epoch information in these logs, it is hard to associate the log with other logs. Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #816 +/- ##
============================================
+ Coverage 70.18% 70.32% +0.13%
============================================
Files 112 112
Lines 61311 61311
============================================
+ Hits 43031 43116 +85
+ Misses 18280 18195 -85
🚀 New features to boost your workflow:
|
Signed-off-by: Binbin <binloveplay1314@qq.com>
PingXie
approved these changes
Aug 23, 2024
madolson
approved these changes
Aug 23, 2024
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
When failover deny to vote, sometimes due to network or some blocking operations, the time of FAILOVER_AUTH_REQUEST packet arrival is very uncertain. Since there is no epoch information in these logs, it is hard to associate the log with other logs. Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
When failover deny to vote, sometimes due to network or some blocking operations, the time of FAILOVER_AUTH_REQUEST packet arrival is very uncertain. Since there is no epoch information in these logs, it is hard to associate the log with other logs. Signed-off-by: Binbin <binloveplay1314@qq.com>
lilpoozie2005
approved these changes
Sep 11, 2024
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
May 25, 2026
…' (merge request !21) Backport cluster optimiztions valkey-io/valkey#633 valkey-io/valkey#780 valkey-io/valkey#782 valkey-io/valkey#816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.