Adjust the log level of some logs in the cluster#633
Merged
Conversation
I think the log of pfail status changes will be very useful. The other parts were scanned and found that it can be modified. Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #633 +/- ##
============================================
- Coverage 70.19% 70.18% -0.01%
============================================
Files 110 110
Lines 60049 60077 +28
============================================
+ Hits 42149 42168 +19
- Misses 17900 17909 +9
🚀 New features to boost your workflow:
|
PingXie
reviewed
Jun 12, 2024
PingXie
left a comment
Member
There was a problem hiding this comment.
Thanks @enjoy-binbin! I like these changes. My only question is around when to use NOTICE and when to use WARNING. I would like to see some discussion/clarification on them.
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
Member
Author
i don't have one, maybe madolson has more insight. |
zuiderkwast
reviewed
Jun 14, 2024
Member
The previous Redis decision was that LL_WARNING should be for system failures that operators should be notified about and can take action on but shouldn't halt the system (like a serverPanic). LL_NOTICE should be notifications that the average user might want to know about when looking back at the log to understand why something happened (replication disconnects, failovers, elections, etc). |
madolson
reviewed
Jun 14, 2024
Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
reviewed
Jun 17, 2024
Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
approved these changes
Jun 17, 2024
hpatro
added a commit
that referenced
this pull request
Jun 6, 2025
…2010) After node failure detection/recovery and gossip by each primary, we log about the failure detection/recovery at NOTICE level which can spam the server and the behavior is quite expensive on ec2 burstable instance types. I would prefer us rolling it back to VERBOSE level. Change was introduced in #633 Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
chzhoo
pushed a commit
to chzhoo/valkey
that referenced
this pull request
Jun 12, 2025
…alkey-io#2010) After node failure detection/recovery and gossip by each primary, we log about the failure detection/recovery at NOTICE level which can spam the server and the behavior is quite expensive on ec2 burstable instance types. I would prefer us rolling it back to VERBOSE level. Change was introduced in valkey-io#633 Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com> Signed-off-by: chzhoo <czawyx@163.com>
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
…alkey-io#2010) After node failure detection/recovery and gossip by each primary, we log about the failure detection/recovery at NOTICE level which can spam the server and the behavior is quite expensive on ec2 burstable instance types. I would prefer us rolling it back to VERBOSE level. Change was introduced in valkey-io#633 Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com> Signed-off-by: shanwan1 <shanwan1@intel.com>
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
May 25, 2026
…' (merge request !21) Backport cluster optimiztions valkey-io/valkey#633 valkey-io/valkey#780 valkey-io/valkey#782 valkey-io/valkey#816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the log of pfail status changes will be very useful.
The other parts were scanned and found that it can be modified.
Changes: