Update versioning fields for compatibility#47
Merged
Conversation
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
PingXie
reviewed
Apr 1, 2024
PingXie
left a comment
Member
There was a problem hiding this comment.
overall, the code change makes sense to me but since we have decided to not break existing redis clients in the first release I think this change should be made after the compat strategy discussion is closed.
zuiderkwast
reviewed
Apr 2, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
I had some pending comments since last week. Posting them now.
zuiderkwast
reviewed
Apr 2, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
commented
Apr 2, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
zuiderkwast
reviewed
Apr 3, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Almost perfect.
I see it includes some Lua fields too. Nice.
Can you update the top comment?
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
zuiderkwast
approved these changes
Apr 3, 2024
hpatro
reviewed
Apr 3, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
hpatro
approved these changes
Apr 3, 2024
zuiderkwast
approved these changes
Apr 3, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This was referenced Apr 5, 2024
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Apr 7, 2024
New info information to be used to determine the valkey versioning info. Internally, introduce new define values for "SERVER_VERSION" which is different from the Redis compatibility version, "REDIS_VERSION". Add two new info fields: `server_version`: The Valkey server version `server_name`: Indicates that the server is valkey. Add one new RDB field: `server_ver`, which indicates the valkey version that produced the server. Add 3 new LUA globals: `SERVER_VERSION_NUM`, `SERVER_VERSION`, and `SERVER_NAME`. Which reflect the valkey version instead of the Redis compatibility version. Also clean up various places where Redis and configuration was being used that is no longer necessary. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Merged
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
New info information to be used to determine the valkey versioning info. Internally, introduce new define values for "SERVER_VERSION" which is different from the Redis compatibility version, "REDIS_VERSION". Add two new info fields: `server_version`: The Valkey server version `server_name`: Indicates that the server is valkey. Add one new RDB field: `server_ver`, which indicates the valkey version that produced the server. Add 3 new LUA globals: `SERVER_VERSION_NUM`, `SERVER_VERSION`, and `SERVER_NAME`. Which reflect the valkey version instead of the Redis compatibility version. Also clean up various places where Redis and configuration was being used that is no longer necessary. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
kovan
added a commit
to kovan/valkey-doc
that referenced
this pull request
Mar 26, 2026
- Fix: the INFO field is valkey_version, not server_version (renamed in valkey-io/valkey#232) - Add Lua globals: SERVER_NAME, SERVER_VERSION, SERVER_VERSION_NUM (added in valkey-io/valkey#47)
kovan
added a commit
to kovan/valkey-doc
that referenced
this pull request
May 14, 2026
- Fix: the INFO field is valkey_version, not server_version (renamed in valkey-io/valkey#232) - Add Lua globals: SERVER_NAME, SERVER_VERSION, SERVER_VERSION_NUM (added in valkey-io/valkey#47) Signed-off-by: Kit Dallege <xaum.io@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New info information to be used to determine the valkey versioning info.
Internally, introduce new define values for "SERVER_VERSION" which is different from the Redis compatibility version, "REDIS_VERSION".
Add two new info fields:
server_version: The Valkey server versionserver_name: Indicates that the server is valkey.Add one new RDB field:
server_ver, which indicates the valkey version that produced the server.Add 3 new LUA globals:
SERVER_VERSION_NUM,SERVER_VERSION, andSERVER_NAME. Which reflect the valkey version instead of the Redis compatibility version.Also clean up various places where Redis and configuration was being used that is no longer necessary.