Update Server version to valkey version#232
Merged
Merged
Conversation
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Contributor
|
Suggest to update function name: test_redisversion in misc.c as well in this PR |
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Contributor
|
LGTM, Thanks |
hwware
approved these changes
Apr 5, 2024
PingXie
approved these changes
Apr 5, 2024
zuiderkwast
approved these changes
Apr 5, 2024
Comment on lines
13297
to
13299
| int RM_GetServerVersion(void) { | ||
| return SERVER_VERSION_NUM; | ||
| return VALKEY_VERSION_NUM; | ||
| } |
Contributor
There was a problem hiding this comment.
Not the scope of this PR, but I wonder whether we should return the Redis compat version here instead.
…alkey_version_update Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Apr 7, 2024
This commit updates the following fields: 1. server_version -> valkey_version in server info. Since we would like to advertise specific compatibility, we are making the version specific to valkey. servername will remain as an optional indicator, and other valkey compatible stores might choose to advertise something else. 1. We dropped redis-ver from the API. This isn't related to API compatibility, but we didn't want to "fake" that valkey was creating an rdb from a Redis version. 1. Renamed server-ver -> valkey_version in rdb info. Same as point one, we want to explicitly indicate this was created by a valkey server. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This was referenced Apr 7, 2024
Merged
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Apr 8, 2024
This commit updates the following fields: 1. server_version -> valkey_version in server info. Since we would like to advertise specific compatibility, we are making the version specific to valkey. servername will remain as an optional indicator, and other valkey compatible stores might choose to advertise something else. 1. We dropped redis-ver from the API. This isn't related to API compatibility, but we didn't want to "fake" that valkey was creating an rdb from a Redis version. 1. Renamed server-ver -> valkey_version in rdb info. Same as point one, we want to explicitly indicate this was created by a valkey server. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
This commit updates the following fields: 1. server_version -> valkey_version in server info. Since we would like to advertise specific compatibility, we are making the version specific to valkey. servername will remain as an optional indicator, and other valkey compatible stores might choose to advertise something else. 1. We dropped redis-ver from the API. This isn't related to API compatibility, but we didn't want to "fake" that valkey was creating an rdb from a Redis version. 1. Renamed server-ver -> valkey_version in rdb info. Same as point one, we want to explicitly indicate this was created by a valkey server. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
kovan
added a commit
to kovan/valkey-doc
that referenced
this pull request
Mar 26, 2026
- Fix: the INFO field is valkey_version, not server_version (renamed in valkey-io/valkey#232) - Add Lua globals: SERVER_NAME, SERVER_VERSION, SERVER_VERSION_NUM (added in valkey-io/valkey#47)
kovan
added a commit
to kovan/valkey-doc
that referenced
this pull request
May 14, 2026
- Fix: the INFO field is valkey_version, not server_version (renamed in valkey-io/valkey#232) - Add Lua globals: SERVER_NAME, SERVER_VERSION, SERVER_VERSION_NUM (added in valkey-io/valkey#47) Signed-off-by: Kit Dallege <xaum.io@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on conversation from #43 (comment). This commit updates the following fields: