Add availability-zone to the reply schema for CLUSTER SHARDS/SLOTS#3352
Merged
Conversation
…t commands `availability_zone` was added to the HELLO command in valkey-io#1487, and it was missing the reply schema and the test was wrongly marked with `logreqres:skip`. `availability-zone` was added to CLUSTER SHARDS and CLUSTER SLOTS commands in valkey-io#3156, and it was missing the reply schema. Signed-off-by: Binbin <binloveplay1314@qq.com>
Member
Author
|
reply CI with this change: https://github.com/enjoy-binbin/valkey/actions/runs/22935935370 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3352 +/- ##
============================================
- Coverage 75.03% 74.93% -0.11%
============================================
Files 129 129
Lines 71724 71724
============================================
- Hits 53821 53748 -73
- Misses 17903 17976 +73
🚀 New features to boost your workflow:
|
Contributor
|
Hahah, I raised a similar fix #3353 5 mins after you. Thank you. I will close my PR. |
sarthakaggarwal97
approved these changes
Mar 11, 2026
Member
Author
|
ohh, you are fast. After merging some PRs i looked through some merged PRs and found it. |
enjoy-binbin
commented
Mar 11, 2026
dvkashapov
approved these changes
Mar 11, 2026
dvkashapov
left a comment
Member
There was a problem hiding this comment.
Nice! Lets run reply schema validator action?
Member
Author
#3352 (comment) |
Member
|
My bad, I thought that was link to failing CI |
zuiderkwast
reviewed
Mar 11, 2026
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
I merged this feature yesterday evening and I realized afterwards that the reply schema will probably fail.
zuiderkwast
reviewed
Mar 11, 2026
Signed-off-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
approved these changes
Mar 11, 2026
Signed-off-by: Binbin <binloveplay1314@qq.com>
Contributor
|
I started the reply-schema-validator job here: https://github.com/valkey-io/valkey/actions/runs/22951771959/job/66617979827 🟢 Pass |
JimB123
pushed a commit
that referenced
this pull request
Mar 19, 2026
…3352) `availability_zone` was added to the HELLO command in #1487, and it was missing the reply schema and the test was wrongly marked with `logreqres:skip`. `availability-zone` was added to CLUSTER SHARDS and CLUSTER SLOTS commands in #3156, and it was missing the reply schema. --------- Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
availability_zonewas added to the HELLO command in #1487, andit was missing the reply schema and the test was wrongly marked
with
logreqres:skip.availability-zonewas added to CLUSTER SHARDS and CLUSTER SLOTScommands in #3156, and it was missing the reply schema.