Fix reply schemas for availability-zone in CLUSTER SLOTS/SHARDS#3353
Closed
sarthakaggarwal97 wants to merge 1 commit into
Closed
Fix reply schemas for availability-zone in CLUSTER SLOTS/SHARDS#3353sarthakaggarwal97 wants to merge 1 commit into
sarthakaggarwal97 wants to merge 1 commit into
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
reply-schemas-validatorfailure introduced by #3156That change added
availability-zoneto the runtime responses forCLUSTER SLOTSandCLUSTER SHARDS, but the command reply schemas were not updated to allow the new field. As a result, req/res validation rejected the new node metadata.This PR updates the reply schemas for both commands and regenerates
src/commands.defso the generated command metadata stays in sync.Failing: https://github.com/valkey-io/valkey/actions/runs/22930288382/job/66550070035