Rename redis.tcl to valkey.tcl by hwware · Pull Request #283 · valkey-io/valkey

hwware · 2024-04-10T17:49:38Z

Test passed.

zuiderkwast

valkey.tcl defines a lot of functions and structures called redis. This is just confusing. If we rename the client lib, rename the functions and types to valkey too, or otherwise just leave it with the name redis.

hwware · 2024-04-10T20:01:03Z

valkey.tcl defines a lot of functions and structures called redis. This is just confusing. If we rename the client lib, rename the functions and types to valkey too, or otherwise just leave it with the name redis.

In this file, a lot of proc and global variables are defined by redis* name. In fact, we can rename all of them to valkey*, do you think this is a branding name issue or just leave them as a redis legacy?

zuiderkwast · 2024-04-10T20:57:20Z

Yes, I think it's a good idea to rename all redis to valkey in the tests. It is safe and the code will still work. Just don't change redis in copyright and license text in the files.

I don't think there is a trademark issue at all in the tests. We can keep "redis" if we want. The only reason to change it is that it is nice to remove it. Do you think it's better to just keep "redis" everywhere in the tests?

enjoy-binbin · 2024-04-11T02:48:16Z

i have seen some PRs doing this rename things (like #287). since now that we have started, let's rename them all in tcl tests.

personally, i want to do this in a big PR so that we don't have a lot of commits. Changing it is very simple, it only needs to pass CI and does not require much review. But i am ok with spitting it into multiple small PRs.

zuiderkwast · 2024-04-11T14:36:25Z

I like @enjoy-binbin's suggestion of one big PR for all TCL tests. If we change exactly everywhere, theoretically everything should work.

"Redis" -> "Valkey"
"redis" -> "valkey"
"REDIS" -> "VALKEY"

zuiderkwast · 2024-04-14T22:48:29Z

This is part of #155 but i see no link between issue and pr.

zuiderkwast · 2024-04-24T11:58:41Z

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

hwware · 2024-04-24T14:59:56Z

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

let me refresh it. Thanks

Signed-off-by: hwware <wen.hui.ware@gmail.com>

codecov · 2024-04-24T18:00:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.37%. Comparing base (8baf322) to head (c8dace1).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable     #283      +/-   ##
============================================
- Coverage     68.40%   68.37%   -0.04%     
============================================
  Files           108      108              
  Lines         61562    61562              
============================================
- Hits          42113    42093      -20     
- Misses        19449    19469      +20

see 13 files with indirect coverage changes

hwware · 2024-04-24T18:04:51Z

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

Rebase done, and pass all tests, pls take a look, Thanks

zuiderkwast

Great!

Includes some more changes e.g. the README under tests and some script under utils. Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Sher Sun <sher.sun@huawei.com>

Squashed 'deps/libvalkey/' changes from b012f8e85..62e757d17 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 62e757d174748642ddd0cefad1ebae3941a6bb92 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (valkey-io#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284) 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Update deps/libvalkey to version 0.4.0 Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (#284) 62e757d17 Release 0.3.0 (#283) a554f0942 Fix potential uint32_t underflow issue (#280) 8f9051ae0 Correcting command parser bug (#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (#245) 15974930d Add option to select a logical database (#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Update deps/libvalkey to version 0.4.0 Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (valkey-io#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284) 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>

hwware requested review from enjoy-binbin, madolson and zuiderkwast April 10, 2024 17:56

zuiderkwast requested changes Apr 10, 2024

View reviewed changes

zuiderkwast mentioned this pull request Apr 14, 2024

Replace all "redis" keywords to "valkey" in tcl test files #155

Closed

rename redis.tcl to valkey.tcl

c8dace1

Signed-off-by: hwware <wen.hui.ware@gmail.com>

hwware force-pushed the rename-redis-tcl branch from 8536a84 to c8dace1 Compare April 24, 2024 17:48

zuiderkwast approved these changes Apr 24, 2024

View reviewed changes

zuiderkwast merged commit 191be27 into valkey-io:unstable Apr 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename redis.tcl to valkey.tcl#283

Rename redis.tcl to valkey.tcl#283
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
hwware:rename-redis-tcl

hwware commented Apr 10, 2024

Uh oh!

zuiderkwast left a comment

Uh oh!

hwware commented Apr 10, 2024

Uh oh!

zuiderkwast commented Apr 10, 2024

Uh oh!

enjoy-binbin commented Apr 11, 2024 •

edited

Loading

Uh oh!

zuiderkwast commented Apr 11, 2024

Uh oh!

zuiderkwast commented Apr 14, 2024

Uh oh!

zuiderkwast commented Apr 24, 2024

Uh oh!

hwware commented Apr 24, 2024

Uh oh!

codecov Bot commented Apr 24, 2024

Uh oh!

hwware commented Apr 24, 2024

Uh oh!

zuiderkwast left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hwware commented Apr 10, 2024

Uh oh!

zuiderkwast left a comment

Choose a reason for hiding this comment

Uh oh!

hwware commented Apr 10, 2024

Uh oh!

zuiderkwast commented Apr 10, 2024

Uh oh!

enjoy-binbin commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zuiderkwast commented Apr 11, 2024

Uh oh!

zuiderkwast commented Apr 14, 2024

Uh oh!

zuiderkwast commented Apr 24, 2024

Uh oh!

hwware commented Apr 24, 2024

Uh oh!

codecov Bot commented Apr 24, 2024

Codecov Report

Uh oh!

hwware commented Apr 24, 2024

Uh oh!

zuiderkwast left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

enjoy-binbin commented Apr 11, 2024 •

edited

Loading