Skip to content

Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange#262

Merged
madolson merged 1 commit into
valkey-io:unstablefrom
9bany:remove/ValkeyModuleEvent_MasterLinkChange
Apr 8, 2024
Merged

Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange#262
madolson merged 1 commit into
valkey-io:unstablefrom
9bany:remove/ValkeyModuleEvent_MasterLinkChange

Conversation

@9bany

@9bany 9bany commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

fixes: #249

@9bany 9bany force-pushed the remove/ValkeyModuleEvent_MasterLinkChange branch from 55a33d4 to 489bbcf Compare April 8, 2024 15:23
Comment thread src/module.c
…LinkChange

Signed-off-by: 0del <bany.y0599@gmail.com>
@9bany 9bany force-pushed the remove/ValkeyModuleEvent_MasterLinkChange branch from 934c902 to db0633d Compare April 8, 2024 15:45
@9bany 9bany requested review from madolson and zuiderkwast April 8, 2024 15:53
@madolson madolson changed the title Remove ValkeyModuleEvent_MasterLinkChange Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange Apr 8, 2024
@madolson madolson merged commit d92dc78 into valkey-io:unstable Apr 8, 2024
madolson pushed a commit to madolson/valkey that referenced this pull request Apr 8, 2024
…yLinkChange (valkey-io#262)

Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange

Signed-off-by: 0del <bany.y0599@gmail.com>
@PingXie

PingXie commented Apr 9, 2024

Copy link
Copy Markdown
Member

I think the Redis event name needs to be reverted back to Master to maintain source compat. Changing Master to Primary is good for the Valkey macro.

RedisModuleEvent_MasterLinkChange

@madolson

madolson commented Apr 9, 2024

Copy link
Copy Markdown
Member

Yes, let's fix this for RC2. We'll see if anyone comments about it.

@madolson

Copy link
Copy Markdown
Member

@PingXie Fix in #289

PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
…yLinkChange (valkey-io#262)

Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange

Signed-off-by: 0del <bany.y0599@gmail.com>
bjosv added a commit to bjosv/valkey that referenced this pull request Feb 16, 2026
Squashed 'deps/libvalkey/' changes from b012f8e85..62e757d17

62e757d17 Release 0.3.0 (valkey-io#283)
a554f0942 Fix potential uint32_t underflow issue (valkey-io#280)
8f9051ae0 Correcting command parser bug (valkey-io#277)
29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h
ae756bc89 Update cmddef.h to Valkey 9.0.0
21abd737e Replace problematic alloca() with fixed stack alloc
38191079c Fix compilation on Solaris with Sun/Solaris Studio
ef5de0312 Make libvalkey initialization thread-safe
ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262)
36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233)
c090c28be Use a uintptr_t hop for casting pointers to ints
daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245)
15974930d Add option to select a logical database (valkey-io#244)
983d67e4f Install the macosx adapter on Apple platforms only
...

git-subtree-dir: deps/libvalkey
git-subtree-split: 62e757d174748642ddd0cefad1ebae3941a6bb92

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv added a commit to bjosv/valkey that referenced this pull request Feb 23, 2026
Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c

45c2ed15c Release 0.4.0 (valkey-io#286)
40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284)
62e757d17 Release 0.3.0 (valkey-io#283)
a554f0942 Fix potential uint32_t underflow issue (valkey-io#280)
8f9051ae0 Correcting command parser bug (valkey-io#277)
29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h
ae756bc89 Update cmddef.h to Valkey 9.0.0
21abd737e Replace problematic alloca() with fixed stack alloc
38191079c Fix compilation on Solaris with Sun/Solaris Studio
ef5de0312 Make libvalkey initialization thread-safe
ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262)
36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233)
c090c28be Use a uintptr_t hop for casting pointers to ints
daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245)
15974930d Add option to select a logical database (valkey-io#244)
983d67e4f Install the macosx adapter on Apple platforms only
...

git-subtree-dir: deps/libvalkey
git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast pushed a commit that referenced this pull request Feb 23, 2026
Update deps/libvalkey to version 0.4.0

Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c

45c2ed15c Release 0.4.0 (#286)
40d6590d7 Implement runtime dynamic loading for RDMA libraries (#284)
62e757d17 Release 0.3.0 (#283)
a554f0942 Fix potential uint32_t underflow issue (#280)
8f9051ae0 Correcting command parser bug (#277)
29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h
ae756bc89 Update cmddef.h to Valkey 9.0.0
21abd737e Replace problematic alloca() with fixed stack alloc
38191079c Fix compilation on Solaris with Sun/Solaris Studio
ef5de0312 Make libvalkey initialization thread-safe
ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (#262)
36f6e2292 Fix the long-blocking read for Valkey RDMA. (#233)
c090c28be Use a uintptr_t hop for casting pointers to ints
daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (#245)
15974930d Add option to select a logical database (#244)
983d67e4f Install the macosx adapter on Apple platforms only
...

git-subtree-dir: deps/libvalkey
git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
Update deps/libvalkey to version 0.4.0

Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c

45c2ed15c Release 0.4.0 (valkey-io#286)
40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284)
62e757d17 Release 0.3.0 (valkey-io#283)
a554f0942 Fix potential uint32_t underflow issue (valkey-io#280)
8f9051ae0 Correcting command parser bug (valkey-io#277)
29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h
ae756bc89 Update cmddef.h to Valkey 9.0.0
21abd737e Replace problematic alloca() with fixed stack alloc
38191079c Fix compilation on Solaris with Sun/Solaris Studio
ef5de0312 Make libvalkey initialization thread-safe
ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262)
36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233)
c090c28be Use a uintptr_t hop for casting pointers to ints
daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245)
15974930d Add option to select a logical database (valkey-io#244)
983d67e4f Install the macosx adapter on Apple platforms only
...

git-subtree-dir: deps/libvalkey
git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Usage of MASTER in module reference

4 participants