Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c#229
Merged
enjoy-binbin merged 6 commits intoApr 18, 2024
Merged
Conversation
57adc7f to
6524a71
Compare
CharlesChen888
approved these changes
Apr 11, 2024
Contributor
Author
|
@zuiderkwast Can you review this when you have sometime? |
zuiderkwast
reviewed
Apr 11, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
All seems good, but I want to separate into separate PRs, for various reasons. That's why it was separated in #25 into separate categories.
- internals (variable names and comments)
- log messages
- other output like usage
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
adca51a to
632e0f0
Compare
enjoy-binbin
approved these changes
Apr 18, 2024
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
… server.c (valkey-io#229) Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Aug 20, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..d95a5ee9a 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 279125e22 Spelling (valkey-io#213) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) f670346b9 Only install headers for `TLS` and `RDMA` when enabled in CMake (valkey-io#206) 41c5911f1 Remove macro UNUSED from public API (valkey-io#200) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) git-subtree-dir: deps/libvalkey git-subtree-split: d95a5ee9ad95b9ee7f298f38d0fb93f3f7659ef7 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Aug 20, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Aug 21, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Aug 21, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
pushed a commit
that referenced
this pull request
Aug 21, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (#205) 178e350c7 Cluster code cleanup (#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212) 99aa158bc Use existing connections for blocking slotmap updates (#199) 969a8c546 Fix dependency issue with RDMA (#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (#205) 178e350c7 Cluster code cleanup (#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212) 99aa158bc Use existing connections for blocking slotmap updates (#199) 969a8c546 Fix dependency issue with RDMA (#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c