Update Valkey startup infomation and other output infomation for Valk… by hwware · Pull Request #205 · valkey-io/valkey

hwware · 2024-04-04T15:59:46Z

Fix Valkey server startup message issue as below

And update some output messages

We will rebase after pr #206 is merged

…ey server Signed-off-by: hwware <wen.hui.ware@gmail.com>

madolson

I think we should decouple the error changes from the other messages here, which I think are easier to make a decision about.

madolson · 2024-04-04T17:50:17Z

+        "-LOADING Server is loading the dataset in memory\r\n"));
    shared.slowevalerr = createObject(OBJ_STRING,sdsnew(
-        "-BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.\r\n"));
+        "-BUSY Server is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.\r\n"));


At AWS we have this hardcoded. there are other places this stuff seems hardcoded: https://github.com/netty/netty/blob/fee3c39d0835ec18d7aace8776db5c5952ce8272/codec-redis/src/main/java/io/netty/handler/codec/redis/FixedRedisMessagePool.java#L44

I think this need to be more thoughtfully considered for compatibility. I'm leaning towards we just accept this as a compatibility problem forever.

Agree, don't change error replies. We'll not do that in the compat release.

Besides, I have a PR for those specifically: #206

hwware · 2024-04-04T18:51:34Z

I think we should decouple the error changes from the other messages here, which I think are easier to make a decision about.

After I rebase #206, I will make the changes only for Valkey server startup issue

zuiderkwast · 2024-04-04T20:06:29Z

I think we decided not to change any logging in the compatibility release. If we follow that strictly, that would mean we can't even change this one, which is like a title:

"oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo"

Shall we make a few exceptions and change this line and a few others in the compat release?

Logging isn't as high risk as error messages though, is it?

enjoy-binbin · 2024-04-05T11:48:57Z


    serverLog(LL_WARNING,"%s is now ready to exit, bye bye...",
-        server.sentinel_mode ? "Sentinel" : "Redis");
+        server.sentinel_mode ? "Sentinel" : "Server");


somehow in here, i prefer Valkey?

Agree with @enjoy-binbin. It's like a greeting. Similar to the logo and this one;

oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo

We can replace that "starting" message with Valkey and different graphics instead of oO0Oo...

zuiderkwast · 2024-04-05T12:12:23Z

 void commandHelpCommand(client *c) {
    const char *help[] = {
 "(no subcommand)",
-"    Return details about all Redis commands.",
+"    Return details about all Valkey commands.",


Let's do help commands in a separate PR too. I did this without seeing your change: #216

zuiderkwast · 2024-04-05T12:15:49Z

This one is partially doing #207.

I believe we decided to skip this for 7.2.4 but I think we should reconsider it. We should at least not printing "Redis is starting" and the Redis logo. If we change those, we can as well change the other occurrences of Redis in the logging.

I'm going to mark this as a major decision. It is about whether to include logging changes in 7.2.4 or if we will postpone it to 8.0.0.

zuiderkwast

This PR is a mix of logging, error replies and HELP output. It's better that we do this in separate PRs. There are also issues for all of these. See #25.

Some of this is already done in other PRs and merged.

@hwware Do you want to re-purpose this PR to do only the logging changes?

zuiderkwast

Don't merge. See #207 (and other issues).

hwware · 2024-04-23T14:08:08Z

Since startup information has been updated in other PR, i prefer to close this PR,

Squashed 'deps/libvalkey/' changes from abcd27fbf..d95a5ee9a 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 279125e22 Spelling (valkey-io#213) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) f670346b9 Only install headers for `TLS` and `RDMA` when enabled in CMake (valkey-io#206) 41c5911f1 Remove macro UNUSED from public API (valkey-io#200) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) git-subtree-dir: deps/libvalkey git-subtree-split: d95a5ee9ad95b9ee7f298f38d0fb93f3f7659ef7 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (#205) 178e350c7 Cluster code cleanup (#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212) 99aa158bc Use existing connections for blocking slotmap updates (#199) 969a8c546 Fix dependency issue with RDMA (#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (#205) 178e350c7 Cluster code cleanup (#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212) 99aa158bc Use existing connections for blocking slotmap updates (#199) 969a8c546 Fix dependency issue with RDMA (#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85 b012f8e85 Release 0.2.1 9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229) 1eadedf48 Remove the unused valDup API from dict a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205) 178e350c7 Cluster code cleanup (valkey-io#216) 4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212) 99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199) 969a8c546 Fix dependency issue with RDMA (valkey-io#201) ... git-subtree-dir: deps/libvalkey git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>

Update Valkey startup infomation and other output infomation for Valk…

6bc8b36

…ey server Signed-off-by: hwware <wen.hui.ware@gmail.com>

hwware requested review from madolson and zuiderkwast April 4, 2024 16:10

madolson reviewed Apr 4, 2024

View reviewed changes

madolson mentioned this pull request Apr 4, 2024

Remove 'Redis' in error replies #206

Merged

enjoy-binbin reviewed Apr 5, 2024

View reviewed changes

zuiderkwast reviewed Apr 5, 2024

View reviewed changes

zuiderkwast added the major-decision-pending Major decision pending by TSC team label Apr 5, 2024

zuiderkwast reviewed Apr 10, 2024

View reviewed changes

zuiderkwast requested changes Apr 11, 2024

View reviewed changes

zuiderkwast removed the major-decision-pending Major decision pending by TSC team label Apr 11, 2024

hwware closed this Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Valkey startup infomation and other output infomation for Valk…#205

Update Valkey startup infomation and other output infomation for Valk…#205
hwware wants to merge 1 commit into
valkey-io:unstablefrom
hwware:Valkey-server-message

hwware commented Apr 4, 2024 •

edited

Loading

Uh oh!

madolson left a comment

Uh oh!

madolson Apr 4, 2024

Uh oh!

zuiderkwast Apr 4, 2024

Uh oh!

hwware commented Apr 4, 2024

Uh oh!

zuiderkwast commented Apr 4, 2024 •

edited

Loading

Uh oh!

enjoy-binbin Apr 5, 2024

Uh oh!

zuiderkwast Apr 5, 2024

Uh oh!

zuiderkwast Apr 5, 2024

Uh oh!

zuiderkwast commented Apr 5, 2024

Uh oh!

zuiderkwast left a comment

Uh oh!

zuiderkwast left a comment

Uh oh!

hwware commented Apr 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

hwware commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

madolson Apr 4, 2024

Choose a reason for hiding this comment

Uh oh!

zuiderkwast Apr 4, 2024

Choose a reason for hiding this comment

Uh oh!

hwware commented Apr 4, 2024

Uh oh!

zuiderkwast commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enjoy-binbin Apr 5, 2024

Choose a reason for hiding this comment

Uh oh!

zuiderkwast Apr 5, 2024

Choose a reason for hiding this comment

Uh oh!

zuiderkwast Apr 5, 2024

Choose a reason for hiding this comment

Uh oh!

zuiderkwast commented Apr 5, 2024

Uh oh!

zuiderkwast left a comment

Choose a reason for hiding this comment

Uh oh!

zuiderkwast left a comment

Choose a reason for hiding this comment

Uh oh!

hwware commented Apr 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hwware commented Apr 4, 2024 •

edited

Loading

zuiderkwast commented Apr 4, 2024 •

edited

Loading