Conversation
017f6ea to
1e5aea8
Compare
kevinkreiser
reviewed
Jul 9, 2020
| if (!linear_reference) { | ||
| return; | ||
| } | ||
| if (options.costing() != Costing::auto_) { |
Member
There was a problem hiding this comment.
We should remove this if, I know that frc will potentially be mostly 7 but that's ok
kevinkreiser
reviewed
Jul 9, 2020
kevinkreiser
previously approved these changes
Jul 9, 2020
Member
kevinkreiser
left a comment
There was a problem hiding this comment.
Other than 2 small comments looks good
added 3 commits
July 9, 2020 11:32
…ialization. In a prior PR (link below) we added OpenLR encoding for trace_route edges but apparently did not check for the API option, defaulting to adding OpenLR linear references to the response. This fixes this issue and adds the options checking to the library function filling out references. #2424 /cc @kevinkreiser
1e5aea8 to
fbbee15
Compare
kevinkreiser
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a prior PR (link below) we added OpenLR encoding for trace_route edges but apparently did not
check for the API option, defaulting to adding OpenLR linear references to the response. This fixes
this issue and adds the options checking to the library function filling out references.
Follow up to:
#2424
/cc @kevinkreiser