Merged
Conversation
Contributor
mandeepsandhu
left a comment
There was a problem hiding this comment.
LGTM. I'll let @kevinkreiser weigh-in on this for final approval.
Modify thor::CostMatrix to make the target map an opaque type. This allows us to entirely encapsulate use of RHH in the implementation, avoiding what otherwise appears to be the only place where use of RHH leaked into the public interface. In particular, this means that consumers no longer need to be able to include the RHH headers. (Which is very fortunate, as we weren't installing them!)
cbecdf0 to
3d29d2d
Compare
Move idtable.h into src/ so that it is explicitly a private header. Also, remove its inclusion from pbfgraphparser.cc, which was not actually using it. This "fixes" the other potential leak of robin-hood-hashing. (Note also the previous commit.)
3d29d2d to
7d8398b
Compare
Member
|
Other than the unneeded changes this looks good |
Contributor
Author
I don't understand what "unneeded changes" you mean. Both changes on which you commented were not present in earlier versions of this PR, which failed CI. |
kevinkreiser
approved these changes
Jul 10, 2020
Member
kevinkreiser
left a comment
There was a problem hiding this comment.
sorry i missed the single line part of the diff where it showed you moved the idtable header to the source directory tree
Contributor
Author
Hehe... yeah, that would do it 😄. No worries, I can totally understand that happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
thor::CostMatrixto make the target map an opaque type. Makeidtable.hexplicitly a private header (by moving it tosrc/) and remove its inclusion frompbfgraphparser.cc, which was not actually using it.This removes all instances of a public (or "public", in the case of
idtable.h) header includingrobin_hood.h, such that our use thereof is totally hidden to consumers rather than leaked into the public interface. In particular, this means that consumers no longer need to be able to include the RHH headers. (Which is very fortunate, as we weren't installing them!)Fixes #2445.